docs: reflect the app-side opener amendment (punchin#278)#11
Merged
Conversation
The app now keeps the opener on its feedback links (no 'noopener' — first-party target; Firefox honours only the opener condition for window.close()). The fetch-based submit remains the load-bearing path for Android Custom Tabs, where the WebAPK->CCT hop severs any opener. Comment + design-spec wording only; no behaviour change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
punchin-feedback | c4a7ad8 | Jun 12 2026, 12:09 AM |
punchIn-app-bot
added
the
documentation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
10 tasks
punchIn-app-bot
added a commit
that referenced
this pull request
Jun 12, 2026
…— punchin#277 (#12) The app side (punchin#277) gates `from=app` on standalone and keeps `noopener,noreferrer` on the feedback links — so the worker never receives a `window.opener` and must not depend on one. The overlay close already works without it (fetch-submitted single-history-entry `window.close()` for Chromium Custom Tabs, native-✕ hint where the engine refuses), which is what CHANGELOG [1.2.0] and render.test.js already document. PR #11 had amended render.js's comment and the design doc to claim the app "keeps the opener" (for Firefox) — contradicting both. This restores consistency: - src/render.js: the close-mechanism comment no longer relies on an opener. - docs/2026-06-07-punchin-feedback-design.md: from=app section matches (standalone- only, noopener, no reverse-tabnabbing surface). Documentation only — no behavior change; worker stays v1.2.0. Tests 103/103, check (wrangler dry-run) passes. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noopener" rationale is stale: both close-permission conditions are now kept true — opener for plain tabs (Firefox honours only that one), single-entry history via fetch-submit for Android Custom Tabs (the WebAPK→CCT hop severs any opener).render.jsrationale comment updated. No behaviour change; CHANGELOG history left as written.Type of change
Checklist
Code
npm testpasses (no behaviour change — comment/doc text only; CI re-runs the suite)npm run check— N/A locally (no source semantics changed); CI runs ittemplates/changed — N/Awrangler.toml [vars]Version & changelog
Documentation
render.jsrationale comment updatedContributor License Agreement
I have read and agree to the PunchIn Feedback Worker Contributor License Agreement.
🤖 Generated with Claude Code