Repository navigation
Normalize hash handling across contract and service boundaries - #36
Merged
MaryammAli merged 1 commit intoJun 23, 2026
Merged
Conversation
- Add HashValidator::validate_for_contract: accepts only SHA-256, explicitly rejects SHA-512 with UnsupportedAlgorithm error - Add HashValidator::hex_to_bytes32: converts validated 64-char hex to [u8; 32] for Soroban BytesN<32> contract calls - Add CacheKey::verification() normalizing constructor: lowercases hash on construction so mixed-case inputs always map to the same cache entry - Update StellarClient::verification_cache_key to use normalizing constructor - Add tests for all new functions; all 96 tests pass Closes Proof-Stell#14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #14
Enforces SHA-256 as the only accepted hash algorithm at every service boundary and provides a tested conversion path from user-provided hex strings to the
BytesN<32>type required by the Soroban contract.Type of Change
Related Issues
Closes #14
Changes Made
HashValidator::validate_for_contract: accepts only 64-char SHA-256 hex, explicitly rejects 128-char SHA-512 withUnsupportedAlgorithm, normalizes to lowercaseHashValidator::hex_to_bytes32: converts a validated hex string to[u8; 32]forBytesN<32>contract callsCacheKey::verification()normalizing constructor: lowercases hash on construction so mixed-case inputs always resolve to the same cache entryStellarClient::verification_cache_keyto use the normalizing constructorTesting
cargo testpasses locallycargo build --target wasm32-unknown-unknown --releasesucceedsChecklist