Skip to content

fix(Import-PSDependModule): Sanitize version string used for Import-Module #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fourpastmidnight wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(Import-PSDependModule): Sanitize version string used for Import-Module #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions PSDepend/Private/Import-PSDependModule.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@
Force = $true
}
if ($Version -and $Version -ne 'latest') {
$importParams.add('RequiredVersion',$Version)
# Sanitize version string. The RequiredVersion parameter is a System.Version and
# doesn't know anything about pre-release tags.
$BaseVersion = ($Version -split '-')[0]
Copy link
Copy Markdown
Member

@HeyItsGilbert HeyItsGilbert May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're still not loading the pre-release in this instance.

$importParams.add('RequiredVersion',$BaseVersion)
Comment on lines 18 to +22
}
Import-Module @importParams
}
}
}
}
Loading