Refactor MIDI event processing and key state updates, format code#379
Open
guylamar2006 wants to merge 1 commit into
Open
Refactor MIDI event processing and key state updates, format code#379guylamar2006 wants to merge 1 commit into
guylamar2006 wants to merge 1 commit into
Conversation
Contributor
Author
|
Fixes #372 |
PolyMeilex
reviewed
May 8, 2026
Comment on lines
+409
to
+410
| // MIDI convention: NoteOn with velocity 0 == NoteOff | ||
| if vel_u8 == 0 { |
Owner
There was a problem hiding this comment.
I'm pretty sure this condition will always be false. Events are already post-processed when they are read to avoid placing velocity conditions everywhere,
Refactor MIDI event handling to support dynamic channel assignment and improve key state management. format refactored rust code with rustfmt
guylamar2006
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor MIDI event handling to support dynamic channel assignment and improve key state management.