Add surf_batch_size to Boozer transform to control memory usage#2267
Merged
Conversation
dpanici
requested review from
a team,
YigitElma,
ddudt,
f0uriest,
rahulgaur104 and
unalmis
and removed request for
a team
July 15, 2026 16:31
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 0.43 % | 4.114e+03 | 4.132e+03 | 17.86 | 31.64 | 30.55 |
test_proximal_jac_w7x_with_eq_update | 0.79 % | 6.560e+03 | 6.612e+03 | 51.80 | 155.88 | 156.73 |
test_proximal_freeb_jac | -0.35 % | 1.336e+04 | 1.331e+04 | -46.42 | 82.03 | 80.95 |
test_proximal_freeb_jac_blocked | -1.14 % | 7.718e+03 | 7.630e+03 | -87.93 | 69.50 | 70.48 |
test_proximal_freeb_jac_batched | 0.01 % | 7.630e+03 | 7.631e+03 | 0.82 | 70.40 | 69.69 |
test_proximal_jac_ripple | -0.55 % | 3.545e+03 | 3.526e+03 | -19.49 | 55.56 | 55.16 |
test_proximal_jac_ripple_bounce1d | -1.87 % | 3.807e+03 | 3.736e+03 | -71.08 | 69.83 | 69.43 |
test_eq_solve | 1.61 % | 1.910e+03 | 1.941e+03 | 30.67 | 58.29 | 58.88 |For the memory plots, go to the summary of |
YigitElma
requested changes
Jul 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2267 +/- ##
==========================================
- Coverage 94.32% 94.32% -0.01%
==========================================
Files 101 101
Lines 28866 28870 +4
==========================================
+ Hits 27229 27232 +3
- Misses 1637 1638 +1
🚀 New features to boost your workflow:
|
YigitElma
reviewed
Jul 16, 2026
YigitElma
approved these changes
Jul 16, 2026
ddudt
reviewed
Jul 17, 2026
ddudt
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine, but has it been tested? Like running a test with multiple surfaces, and using this to only compute a few surfaces at a time.
ddudt
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
surf_batch_sizeas a kwarg to the Boozer transform compute variables to allow control of memory usage when using with large number of surfacesQuasisymmetryBoozerandOmnigenityobjectivesmake_boozmn_outpututility functionEspecially helpful when making high res boozmn.nc using DESC