test(dgram): expand granular Node parity coverage#6442
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesdgram parity coverage
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test-parity/node-suite/dgram/lifecycle/bind-error-retry.ts`:
- Around line 11-13: Annotate the error callback parameter in the candidate.once
error handler as NodeJS.ErrnoException (or an equivalent type containing code
and syscall) so those properties compile under strict TypeScript settings.
Preserve the existing resolve format and behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 83c2e1fa-7aa9-456f-b791-cf4269cf9143
📒 Files selected for processing (10)
test-parity/node-suite/dgram/STATUS.mdtest-parity/node-suite/dgram/connection/connect-ordering.tstest-parity/node-suite/dgram/lifecycle/bind-error-retry.tstest-parity/node-suite/dgram/lifecycle/close-ordering.tstest-parity/node-suite/dgram/metrics/create-socket-buffer-options.tstest-parity/node-suite/dgram/send/empty-array.tstest-parity/node-suite/dgram/send/implicit-bind-state.tstest-parity/node-suite/dgram/validation/buffer-bounds.tstest-parity/node-suite/dgram/validation/message-views.tstest-parity/node_suite_baseline.json
🚧 Files skipped from review as they are similar to previous changes (2)
- test-parity/node-suite/dgram/validation/message-views.ts
- test-parity/node_suite_baseline.json
…m-parity # Conflicts: # test-parity/node_suite_baseline.json
Summary
Expand the granular
node:dgramparity suite from 4 broad fixtures to 38 focused fixtures, using current Node, Deno, and Bun compatibility corpora as primary evidence. The suite now preserves 18 passing behaviors and 20 stable Perry differences as diagnostic regression cases.Changes
sendto(), DataView and scatter-gather sends, connected range guards, custom lookup, close/dispose and connect ordering, bind conflicts/retries, block lists, DNS error routing, constructor buffer options, send bounds, empty arrays, implicit binding, TTL boundaries, constructor listeners, and callback byte countstest-parity/node-suite/dgram/STATUS.mdRelated issue
n/a — standalone parity-suite expansion.
Test plan
cargo build --releaseclean (performed by the focused parity wrapper before the fixture-only follow-up)cargo test --workspace --exclude perry-ui-ios --exclude perry-ui-tvos --exclude perry-ui-watchos --exclude perry-ui-gtk4 --exclude perry-ui-android --exclude perry-ui-windowspasses — not run; no Rust source changedtest-parity/node-suite/dgram/STATUS.mdScreenshots / output
The focused baseline runner completed with 18 passes, 20 stable output diffs, and no
compile_fail,perry_err, ornode_errbuckets.Checklist
Summary by CodeRabbit
dgramparity with new UDP socket scripts covering connection state transitions, connect/disconnect ordering, bind/close behavior, abort-signal handling, TTL/setMulticastTTL validation, and buffer/queue metrics.dgramparity status report with fixture counts, deterministic comparison rules, and enumerated behavioral differences.dgrambaseline thresholds to 18/38.