Skip to content

approx kde - #22

Closed
Parskatt wants to merge 2 commits into
mainfrom
approx-kde
Closed

approx kde#22
Parskatt wants to merge 2 commits into
mainfrom
approx-kde

Conversation

@Parskatt

@Parskatt Parskatt commented Feb 7, 2024

Copy link
Copy Markdown
Owner

No description provided.

@Parskatt

Parskatt commented Feb 7, 2024

Copy link
Copy Markdown
Owner Author

@ducha-aiki can you check this out?

@ducha-aiki

Copy link
Copy Markdown

Thank you, will check tomorrow

@Parskatt

Parskatt commented Feb 8, 2024

Copy link
Copy Markdown
Owner Author

It could also work to replace the balanced sampling with NMS kind of similar to casmtr. Havent tried though.

Basically we just want a nice spread of the matches.

@ducha-aiki

Copy link
Copy Markdown
    matches, match_certainty = matcher.sample(warp, certainty, num=roma_max_matches)
  File "/RoMa/roma/models/matcher.py", line 487, in sample
    density = approx_kde(good_matches, std=0.1)
  File "/RoMa/roma/utils/kde.py", line 16, in approx_kde
    y = torch.multinomial(x, min(max_num_cmp,len(x.shape[-2])), replacement=False)
TypeError: object of type 'int' has no len()

@Parskatt

Copy link
Copy Markdown
Owner Author

Moved to #23

@Parskatt Parskatt closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants