fix: prevent character-colon from consuming semicolon comment delimiter#589
Open
fltLi wants to merge 1 commit intoOpenWebGAL:devfrom
Open
fix: prevent character-colon from consuming semicolon comment delimiter#589fltLi wants to merge 1 commit intoOpenWebGAL:devfrom
fltLi wants to merge 1 commit intoOpenWebGAL:devfrom
Conversation
Modify the regex for character-colon pattern to stop matching character name at an unescaped semicolon. This prevents the colon inside a comment from being incorrectly treated as a statement operator when a semicolon appears before it in the line.
Contributor
Author
|
备注: 此错误原本存在, 并非 #584 引入. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the regex for the character-colon highlighting pattern in hl.json to exclude semicolons from character names, preventing incorrect matches. The reviewer suggests applying a similar fix to the utterance-semicolon pattern at line 230 to ensure consistency and avoid misidentifying comments as utterances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
脚本编辑器语法高亮配置有误: 当首个
:出现在;后时, 会将:前的内容视为指令而非注释.