spec: gui-1.md — one player time convention; confirm/select reserved#108
Draft
JarbasAl wants to merge 1 commit into
Draft
spec: gui-1.md — one player time convention; confirm/select reserved#108JarbasAl wants to merge 1 commit into
JarbasAl wants to merge 1 commit into
Conversation
Unify SYSTEM_audio_player on the SYSTEM_media_player convention: position/duration in milliseconds, -1 = unknown/live — one convention for one semantic pair of fields. Move SYSTEM_confirm / SYSTEM_select to a reserved-for-future section: their reply leg has no specified topic/payload, making them unimplementable interoperably; the names stay reserved so applications cannot claim them. __idle gains an explicit false row and a RECOMMENDED 30 s default for the omitted case. Version bumps to 2 (incompatible with the pre-spec seconds convention). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refines OVOS-GUI-1 for internal purity.
Changes
SYSTEM_audio_playerposition/durationnow count in milliseconds with-1= unknown/live, matchingSYSTEM_media_player. Two templates sharing one screen role must not disagree on units; a normative paragraph states the uniform convention.SYSTEM_confirm/SYSTEM_select→ reserved for a future version (§3.4, §7.2). Their display leg is trivial, but the reply leg (interaction event carrying the answer) has no specified topic or payload schema — an unspecified reply makes the templates unimplementable interoperably. Names stay reserved so applications cannot claim them; producers MUST NOT emit them in this version. Conformance items referencing the reply leg removed (§8.1, §8.5).__idle: explicitfalserow; omitted-__idledeployment default now carries a RECOMMENDED value (30 s) instead of being fully unspecified — tuning value, so RECOMMENDED, not MUST.🤖 Generated with Claude Code