Feature/oals rt shim#4
Conversation
Moi78
left a comment
Moi78
left a comment
There was a problem hiding this comment.
Clean implementation. Not much to say.
| std::cerr << "Failed to set affinity..." << std::endl; | ||
| } | ||
| } | ||
| #include <OpenAudioNetwork/netutils/rt.h> |
There was a problem hiding this comment.
Style: OAN is a "local" library, not a system one, so it should use quotes instead of brackets
There was a problem hiding this comment.
Ok, understood. Is this a project preference or a general C++ thing?
There was a problem hiding this comment.
More a general cpp thing. But it is just styling, it doesn't change anything regarding functionality
| std::cerr << "Failed to set thread realtime..." << std::endl; | ||
| } | ||
| } | ||
| #include <OpenAudioNetwork/netutils/rt.h> |
There was a problem hiding this comment.
Same comment as in engine/main.cpp
| #include <cmath> | ||
| #include <chrono> | ||
| #include <queue> | ||
| #include <ctime> |
There was a problem hiding this comment.
Maybe I missed the line, but I can't see where this header is used.
In C++ we prefer to use the std::chrono library. (Btw that library is a great example of how annoying deep namespaces are)
2 participants
Here Linux CI also fails, because of ALSA in io_sim. But since I'd remove that next, I don't see a point in getting it running here first.
Not yet ready for merge, since OAN should be merged first and the submodule updated here