Skip to content

SkiaSharp and JPEG and JPEG2000 have issues #157

Description

@IainMcCracken

There are issues with encoding SKBitmap and friends as JPEG (SkiaSharp encoder) and as JPEG2000 (CoreJ2K encoder).

The Skia encoder (SKImage.Encode()) fails silently if it cannot produce a regular JPEG (it does not throw, it returns null). This is due to the pixel format (SKColorType) being wrong in the current code base. (Not invalid, just a pixel format that the encoder can't handle.)

On the grid side, this results in Robust failing to save "zoomed" map tiles when a region adds a level 1 map tile, and the viewer being left with no world map, or going with cached old zoom tiles.

On the region side, this results in prim and land-sale etc overlays not being included in map tiles, so what is added to the world map is terrain only.

The Skia encoder (to JPEG) works well with SKColorType.Bgra8888 which is coincidentally the pixel format that Warp3D uses when rendering a scene to SKBitmap.

I will be grooming the code to make the conversions to/from Skia objects and JPEG/JPEG2000 work.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions