Fix/apple silicon aov allocation - #16
Open
gripeyes wants to merge 6 commits into
Open
Conversation
* WIP * light instancing first version * fix tests, update packages * CR fixes * another CR fix * material/light linking * move hats to usdrecord * support hats tests in 2.0 mode * renable subset light linking * create MoonrayScene * factor out Options from RenderDelegate * fix and test MoonrayMeshLight * tidy up class names * clean up tokens * motion blur changes * minor fixes * add back default light * inputs: allowed on custom attrs * version to 10.0 * added simplify paths option for testing * fix crash on exit * add RenderSettings support * remove stray debug print * HDM-408 : changes from OMR PR#8 * fix instancing issue, add option to limit geom tess * fix inst selection, remove nested inst selection * add back nested inst selection * [skip ci] Bumped minor version for the release. * factor out scene_rdl2 specifics * clean up render outputs * scene_rdl2 cleanup * [skip ci] Bumped minor version for the release. * fix compile error for usd 0.25.11 * [skip ci] Bumped minor version for the release. * terminal proxies (disabled) * disable build for usd<0.25.5 --------- Co-authored-by: Rob Wilson <rwilson@dreamworks.com> Co-authored-by: 206531218_nbcuni <toshi.kato@dreamworks.com> Co-authored-by: 206676206_nbcuni <Dan.McCann@dreamworks.com> Co-authored-by: 206689199_nbcuni <Ashley.Lee@dreamworks.com> Signed-off-by: Rob Wilson <rwilson@dreamworks.com> Signed-off-by: Rob Wilson <rob.wilson@dreamworks.com>
Signed-off-by: Rob Wilson <rwilson@dreamworks.com> Signed-off-by: Rob Wilson <rob.wilson@dreamworks.com>
Signed-off-by: Rob Wilson <rwilson@dreamworks.com> Signed-off-by: Rob Wilson <rob.wilson@dreamworks.com>
Signed-off-by: Rob Wilson <rwilson@dreamworks.com> Signed-off-by: Rob Wilson <rob.wilson@dreamworks.com>
Signed-off-by: Rob Wilson <rwilson@dreamworks.com> Signed-off-by: Rob Wilson <rob.wilson@dreamworks.com>
Signed-off-by: Jakub Svoboda <132791205+rolledhand@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility:
patch
Issues/Tickets:
OpenMoonRay/openmoonray#276
OpenMoonRay/openmoonray#272
#14
Release notes comment:
Fixed HdMoonray render-buffer and AOV allocation updates on Apple Silicon.
Comments for the reviewer:
This PR is stacked directly on the head of #14 (
85e63fc), Rob’shdm_10branch. Once #14 merges intomain, this PR will contain only the AOV allocation commit.The existing allocation path initialized a buffer only when its data pointer was empty and forced beauty output to four channels. It did not reallocate when the requested dimensions or channel count changed.
This change:
This complements the Apple Silicon half-conversion fixes in OpenMoonRay/openmoonray#272. Those lower-level conversion changes remain separate.
Umbrella validation PR:
OpenMoonRay/openmoonray#276
Houdini 22 build notes:
https://github.com/gripeyes/openmoonray/blob/test/houdini22-clean-build/building/macOS/Houdini22_build_notes.md
Look or scene setup change:
No scene-setup change. This corrects render-buffer and AOV display output when their requested layout changes.
Special notes for production:
Attention/Reviewers:
@robwilson-dwa
AI Assisted Development:
Assisted-by: OpenAI Codex / GPT-5.6
Checklist: