fix bug that caused LB/UB to not be enforced by remote component if limit was (scalar) 0#239
Merged
Merged
Conversation
Collaborator
Author
|
Also added an additional option, stop_server_for_down_time, to remote components. In my case, I have a server that would only occasionally be called (to compute multi-fidelity corrections), leading to the HPC job just sitting idle for long periods of time. This allows the HPC job to be shut down between calls, either after each function (=1) or derivative (=2) call. This probably won't be useful for most applications, but gives the user a little more flexibility. |
kejacobson
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent functions _lower_bound_used and _upper_bound_used on the client side mistakenly returned bound instead of bound>-1e20 or bound<1e20, if the lower/upper bound returned from the server side was a scalar. I think that caused any constraints of limits of a scalar zero to not be enforced on the client side.