[openipc-ai]

Fixes #209: on the HiSilicon / Goke machines whose kernel inverts the SDHCI write-protect pin, every -drive if=sd card came up read-only in the guest.

What changed

• HisiSoCConfig.sdhci_wp_inverted. When it's set, the SDHCI loop sets wp-inverted on generic-sdhci.

• It's set where the kernel driver carries SDHCI_QUIRK_INVERTED_WRITE_PROTECT:

  machines	kernel (OpenIPC/linux branch)	driver
  hi3516ev200, hi3516ev300, hi3518ev300, hi3516dv200	hisilicon-hi3516ev200	sdhci-hisi.c
  gk7205v200/v300, gk7201v200, gk7202v300, gk7605v100 (HISI_V4_COMMON_PERIPH)	goke-gk7205v200	sdhci-goke.c
  gk7205v500/v510/v530, gk7202v330 (same macro)	goke-gk7205v500	sdhci-xmedia-common.c
  gk7206v10, gk7206v12a (GK7206_XMORCA_PERIPH, via the macro)	goke-gk7206v100	lotus/.../sdhci-lotus-common.c

• It's left unset on hi3516cv608/cv610/cv613 and hi3519dv500/hi3516dv500. Their nebula driver (drivers/vendor/mmc) uses the spec polarity, which QEMU already gives it.

• New qemu/tests/test-hisi-sdhci-wp.sh, run in the CI build job and listed in CLAUDE.md.

Evidence

bash qemu/tests/test-hisi-sdhci-wp.sh: master gives 2 passed, 8 failed (every inverted machine reads PRNSTS 0x01ff0000, WP bit 1). This branch gives 10 passed, 0 failed (inverted machines 0x01f70000; nebula controls unchanged at 0x01ff0000).

Booted from synthetic NOR (the test-flash-rw.sh layout) with the OpenIPC lite releases in qemu-boot/ and a FAT32 card:

machine	master	this branch
hi3516ev300	mmcblk0: mmc0:3244 QEMU! 64.0 MiB (ro) → vfat ro	mmcblk0: mmc0:7438 QEMU! 64.0 MiB → vfat rw
gk7205v200	(ro), same as ev300	mmcblk0: mmc0:6b5f QEMU! 64.0 MiB → vfat rw

Not covered

• gk7205v500: the release kernel boots to login but probes no SD host at all, with or without this change (CONFIG_MMC_SDHCI_XMEDIA=y and nothing binds). For that machine the polarity is covered only by the register test. The missing probe is a separate gap.
• Read-only cards: not testable. QEMU 10.2 refuses a read-only drive as an SD card.
• Nebula and gk7206 boots: no boot-level run on those machines.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Match HiSilicon and Goke SDHCI write-protect polarity to guest drivers

🐞 Bug fix 🧪 Tests 📝 Documentation 🕐 20-40 Minutes

AI Description

• Invert SDHCI write-protect polarity on machines whose guest drivers require it, so writable cards
 mount read-write.
• Preserve spec polarity on nebula-driven machines.
• Add register-level coverage for both polarities and run it in CI.

Diagram

graph TD
  Config["SoC config"] --> Quirk{"Driver inverts WP?"} -->|yes| Inverted["Inverted polarity"] --> SDHCI["Generic SDHCI"] --> Driver["Guest SD driver"] --> Mount["Writable SD card"]
  Quirk -->|no| Spec["Spec polarity"] --> SDHCI

Loading

High-Level Assessment

Keep the per-SoC flag and set the existing generic-sdhci property during common initialization. Globally reversing polarity would regress nebula-driven machines; a separate controller model is unnecessary for a property the existing device already supports.

Files changed (5) +107 / -0

Bug fix (2) +17 / -0

hisilicon.cConfigure SDHCI write-protect polarity per SoC +13/-0

Configure SDHCI write-protect polarity per SoC

• Enables inverted polarity for four EV200-family configurations and the shared Goke V4 configurations. Passes each configuration's polarity to generic-sdhci during controller initialization.

qemu/hw/arm/hisilicon.c

hisilicon.hAdd an SDHCI polarity setting to SoC configuration +4/-0

Add an SDHCI polarity setting to SoC configuration

• Adds sdhci_wp_inverted to HisiSoCConfig, allowing affected machines to opt in while others retain the default polarity.

qemu/include/hw/arm/hisilicon.h

Tests (1) +83 / -0

test-hisi-sdhci-wp.shCheck writable-card WP status across machine families +83/-0

Check writable-card WP status across machine families

• Attaches a writable SD image and checks PRNSTS bit 19 on eight inverted-polarity machines and two nebula controls. Reports unreadable registers and polarity mismatches as failures.

qemu/tests/test-hisi-sdhci-wp.sh

Documentation (1) +1 / -0

CLAUDE.mdList the SDHCI polarity test +1/-0

List the SDHCI polarity test

• Adds the test command to the documented device-register test list.

CLAUDE.md

Other (1) +6 / -0

ci.ymlRun SDHCI polarity regression test in CI +6/-0

Run SDHCI polarity regression test in CI

• Adds the HiSilicon/Goke write-protect test to the build job so polarity regressions are caught automatically.

.github/workflows/ci.yml

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗