Repository navigation
fix(e2e): apply cold-start budget to Tavily test conversation readiness - #1245
Draft
aivong-openhands wants to merge 1 commit into
Draft
aivong-openhands wants to merge 1 commit into
aivong-openhands wants to merge 1 commit into
Conversation
The Tavily test raised its per-test cap to 240s to absorb sandbox cold starts, but called waitForConversationReady() with no argument, so readiness stayed capped at its 120s default. A cold start beyond 120s therefore failed readiness before the conversation ran (Error: Conversation did not become ready within 120000ms, observed on unstable) despite the larger per-test budget going unused. Pass an explicit 180s readiness budget and raise the per-test cap to 360s so readiness plus the prompt/answer waits fit. Co-authored-by: openhands <openhands@all-hands.dev>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The "should be able to use Tavily search" test set a 240s per-test cap to absorb a sandbox cold start, but called
waitForConversationReady()with no argument, leaving readiness pinned to its 120s default. A cold start past 120s then failed readiness (Error: Conversation did not become ready within 120000ms) before the conversation ran, with the reserved budget unused. This passes an explicit 180s readiness budget and raises the per-test cap to 360s so readiness plus the prompt and answer waits (180s each) fit within it.waitForConversationReady()is a deterministic, web-first wait that races the "Waiting for task" state against the error banner, so widening its budget accommodates a genuinely slow cold start without masking failures — a conversation that errors still fails fast, and one that never provisions still fails at 180s.This PR was drafted by an AI agent on behalf of the user.