Fix: print warning/error console messages (Intel Fortran compiler) - #3419
Open
RBergua wants to merge 3 commits into
Open
Fix: print warning/error console messages (Intel Fortran compiler)#3419RBergua wants to merge 3 commits into
RBergua wants to merge 3 commits into
Conversation
Contributor
|
This is interesting. It looks like this became a problem in commit 7ab2d0c. My version of the code has this: 
Setting the value of MaxWrScrLen relative to ConRecL and adding comments might be less prone to issues with mismatches in the future. I would recommend that the other Sys*.f90 file be updated in a similar way. |
Contributor
Author
|
As proposed by @bjonkman , I defined
I confirm that the compiled version with these modifications displays the proper messages: |
andrew-platt
approved these changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure warning/error console output is reliably printed across compilers—especially Intel Fortran—by aligning console record-length limits with the maximum line length used by WrScr.
Changes:
- Increased
ConRecLin severalSys*.f90system modules. - Tied
MaxWrScrLentoConRecL(currentlyMaxWrScrLen = ConRecL-1) to avoid record-length overruns. - Minor whitespace/comment formatting cleanup in
SysIVF.f90.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/nwtc-library/src/SysMatlabLinuxIntel.f90 | Updates console-length parameters for Intel/Linux Matlab system module. |
| modules/nwtc-library/src/SysMatlabLinuxGnu.f90 | Updates console-length parameters for GNU/Linux Matlab system module. |
| modules/nwtc-library/src/SysIVF.f90 | Updates console-length parameters and comment formatting for Intel Visual Fortran (Windows). |
| modules/nwtc-library/src/SysIVF_Labview.f90 | Updates console-length parameters for Intel Visual Fortran (Windows/LabVIEW). |
| modules/nwtc-library/src/SysGnuLinux.f90 | Updates console-length parameters for GNU/Linux system module. |
| modules/nwtc-library/src/SysFlangLinux.f90 | Updates console-length parameters for Flang/Linux system module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+58
to
+60
| INTEGER, PARAMETER :: ConRecL = 180 ! The record length for console output (maximum number of characters that can be written in WrOver(), must be larger than MaxWrScrLen) | ||
| INTEGER, PUBLIC :: CU = 6 ! The I/O unit for the console (Can be changed with SetConsoleUnit subroutine) | ||
| INTEGER, PARAMETER :: MaxWrScrLen = 256 ! The maximum number of characters allowed to be written to a line in WrScr | ||
| INTEGER, PARAMETER :: MaxWrScrLen = ConRecL-1 ! The maximum number of characters allowed to be written to a line in WrScr, must be smaller than ConRecL |
Comment on lines
+57
to
+59
| INTEGER, PARAMETER :: ConRecL = 180 ! The record length for console output (maximum number of characters that can be written in WrOver(), must be larger than MaxWrScrLen) | ||
| INTEGER, PUBLIC :: CU = 6 ! The I/O unit for the console. Unit 6 causes ADAMS to crash. | ||
| INTEGER, PARAMETER :: MaxWrScrLen = 256 ! The maximum number of characters allowed to be written to a line in WrScr | ||
| INTEGER, PARAMETER :: MaxWrScrLen = ConRecL-1 ! The maximum number of characters allowed to be written to a line in WrScr, must be smaller than ConRecL |
Comment on lines
+61
to
+63
| INTEGER, PARAMETER :: ConRecL = 180 ! The record length for console output (maximum number of characters that can be written in WrOver(), must be larger than MaxWrScrLen) | ||
| INTEGER, PUBLIC :: CU = 6 ! The I/O unit for the console (Can be changed with SetConsoleUnit subroutine) | ||
| INTEGER, PARAMETER :: MaxWrScrLen = 256 ! The maximum number of characters allowed to be written to a line in WrScr | ||
| INTEGER, PARAMETER :: MaxWrScrLen = ConRecL-1 ! The maximum number of characters allowed to be written to a line in WrScr, must be smaller than ConRecL |
Comment on lines
+61
to
+63
| INTEGER, PARAMETER :: ConRecL = 180 ! The record length for console output (maximum number of characters that can be written in WrOver(), must be larger than MaxWrScrLen) | ||
| INTEGER, PUBLIC :: CU = 6 ! The I/O unit for the console (Can be changed with SetConsoleUnit subroutine) | ||
| INTEGER, PARAMETER :: MaxWrScrLen = 256 ! The maximum number of characters allowed to be written to a line in WrScr | ||
| INTEGER, PARAMETER :: MaxWrScrLen = ConRecL-1 ! The maximum number of characters allowed to be written to a line in WrScr, must be smaller than ConRecL |
Comment on lines
+58
to
+60
| INTEGER, PARAMETER :: ConRecL = 180 ! The record length for console output (maximum number of characters that can be written in WrOver(), must be larger than MaxWrScrLen) | ||
| INTEGER, PUBLIC :: CU = 7 ! The I/O unit for the console (Can be changed with SetConsoleUnit subroutine) | ||
| INTEGER, PARAMETER :: MaxWrScrLen = 256 ! The maximum number of characters allowed to be written to a line in WrScr | ||
| INTEGER, PARAMETER :: MaxWrScrLen = ConRecL-1 ! The maximum number of characters allowed to be written to a line in WrScr, must be smaller than ConRecL |
Comment on lines
+75
to
+77
| INTEGER, PARAMETER :: ConRecL = 180 ! The record length for console output (maximum number of characters that can be written in WrOver(), must be larger than MaxWrScrLen) | ||
| INTEGER, PUBLIC :: CU = 7 ! The I/O unit for the console (Can be changed with SetConsoleUnit subroutine) | ||
| INTEGER, PARAMETER :: MaxWrScrLen = 256 ! The maximum number of characters allowed to be written to a line in WrScr | ||
| INTEGER, PARAMETER :: MaxWrScrLen = ConRecL-1 ! The maximum number of characters allowed to be written to a line in WrScr, must be smaller than ConRecL |
Comment on lines
+61
to
62
| INTEGER, PARAMETER :: ConRecL = 180 ! The record length for console output (maximum number of characters that can be written in WrOver(), must be larger than MaxWrScrLen) | ||
| INTEGER, PUBLIC :: CU = 6 ! The I/O unit for the console (Can be changed with SetConsoleUnit subroutine) |
Comment on lines
+279
to
+281
| !> This routine sets the values of NaN_D, Inf_D, NaN, Inf (IEEE | ||
| !! values for not-a-number and infinity in sindle and double | ||
| !! precision) This uses standard F03 intrinsic routines, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
On builds compiled with Intel Fortran compiler (e.g., using GitHub Actions), some console messages do not appear. They are never printed, with no indication anything went wrong.
In
SysIVF.f90, it was defined:INTEGER, PARAMETER :: ConRecL = 120 ! The record length for console output.Note that the same file defines:
INTEGER, PARAMETER :: MaxWrScrLen = 256 ! The maximum number of characters allowed to be written to a line in WrScrSo, before, we could have messages writen to screen (
WrScr) of up to 256 characters (allowed length). But only messages up to 120 characters (ConRecL) actually got accepted by the console output write. Anything longer was silently dropped.Interestingly, this only affected the Intel Fortran compiler, not gfortran. For example, compiling locally with GCC 15.2.0 showed the correct behavior, with all messages printed as expected. This indicates that the Intel Fortran compiler strictly enforces the length limit on
WRITEstatements, while GCC is more permissive.Below you can find screenshots illustrating all this using AeroDyn standalone:
GCC 15.2.0 compiler:
Intel Fortran compiler (GitHub Actions via
deploy.yml)Intel Fortran compiler after the fix:
Related issue, if one exists
Fixes #3418