Skip to content

Upgrade FFTPACK 4.1 -> 5.1, add 2D FFT #3412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-platt wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Upgrade FFTPACK 4.1 -> 5.1, add 2D FFT #3412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9cb8a49
Phase 1: Add aggregated FFTPACK 5.1 source
andrew-platt Jul 30, 2026
87bdfb6
Phase 2: Update NWTC_FFTPACK.f90 wrapper for FFTPACK 5.1
andrew-platt Jul 30, 2026
4e1807a
Phase 3: Update CMakeLists.txt for FFTPACK 5.1
andrew-platt Jul 30, 2026
61cc82a
Phase 4: Document regression test results
andrew-platt Jul 30, 2026
dda59f4
Add FFTPACK 5.1 unit tests to nwtc-library test suite
andrew-platt Jul 30, 2026
31f7505
Remove development file
andrew-platt Jul 30, 2026
5e3409a
Update VS build: fftpack4.1 -> fftpack5.1 with RealKIND4
andrew-platt Jul 30, 2026
bc56793
Add 2D FFT wrapper routines and unit tests
andrew-platt Jul 30, 2026
381ea99
Add IER error checks on all FFTPACK calls
andrew-platt Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modules/nwtc-library/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ set(NWTCLIBS_SOURCES
src/Polynomial/quartic.f90

# NetLib sources
src/NetLib/fftpack/fftpack4.1.f
src/NetLib/fftpack/fftpack5.1.f
src/NetLib/scalapack/dlasrt2.f
src/NetLib/scalapack/slasrt2.f
src/NetLib/fftpack/NWTC_FFTPACK.f90
Expand All @@ -124,6 +124,13 @@ set(NWTCLIBS_SOURCES

get_filename_component(FCNAME ${CMAKE_Fortran_COMPILER} NAME)

# FFTPACK 5.1 uses legacy Fortran 77 type punning (COMPLEX<->REAL) and must
# NOT be promoted to double precision (its callers pass explicit SiKi/R4Ki arrays).
if (${CMAKE_Fortran_COMPILER_ID} STREQUAL "GNU")
set_source_files_properties(src/NetLib/fftpack/fftpack5.1.f PROPERTIES COMPILE_FLAGS
"-fallow-argument-mismatch -fno-default-real-8 -fno-default-double-8")
endif()

# Recursive use of routine in qk61/dqk61 will trigger errors in debug
if (CMAKE_BUILD_TYPE MATCHES Debug)
if (${CMAKE_Fortran_COMPILER_ID} STREQUAL "GNU")
Expand Down
608 changes: 526 additions & 82 deletions modules/nwtc-library/src/NetLib/fftpack/NWTC_FFTPACK.f90
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading