Repository navigation
refactor(deploy): move frontend delivery to GHCR and simplify compose workflow - #108
Merged
brokermr810 merged 5 commits intoMay 17, 2026
Merged
Conversation
The Vue source lives in the private QuantDinger-Vue repo, which now
publishes ghcr.io/brokermr810/quantdinger-frontend on every v* tag.
Consuming that image directly removes ~21 MB of build artefacts and
44 dist-touching commits from this repo's history going forward.
- docker-compose.yml: frontend service switches from build: to
image: ${FRONTEND_IMAGE:-ghcr.io/brokermr810/quantdinger-frontend}.
- Remove frontend/ (dist/, dist.zip, Dockerfile, nginx.conf.template,
railway.json) — superseded by the published image.
- Remove scripts/build-frontend.{sh,ps1} and
scripts/private-frontend-ci.yml.example — manual dist-sync flow gone.
- .github/workflows/docker-publish.yml: drop the frontend job; the
Vue repo's release-frontend.yml owns that path now.
- Delete .github/workflows/update-frontend.yml (auto-sync no longer needed).
- .github/workflows/basic-ci.yml: drop the frontend-check job that
asserted frontend/dist existed.
- .gitignore / .dockerignore: clean up the dist-allowlist exceptions.
- Docs (README, CONTRIBUTING, DEVELOPMENT, docs/README_*.md,
docs/CLOUD_DEPLOYMENT_*.md, docs/FRONTEND_FAST_ANALYSIS.md):
rewrite the "npm run build -> replace frontend/dist" narrative as
"tag v* -> auto-publish to GHCR".
After pushing the backend image to GHCR, action-gh-release@v2 publishes a Release with GitHub-generated changelog and a pull snippet. Tag pushes only — workflow_dispatch still produces just a short-SHA image. Bumps `contents` permission to write.
When a Release is drafted through the GitHub web UI before the tag is pushed, the workflow would silently overwrite the hand-written changelog. Set append_body: true so the workflow body is appended after existing notes instead of replacing them.
IMAGE_TAG remains the primary, lockstep knob — set it once and both
images move together. The new BACKEND_TAG / FRONTEND_TAG variables are
opt-in escape hatches for cases like "pin a frontend hotfix against
the stable backend". Whichever side is not overridden still follows
IMAGE_TAG, so the common case stays a single var.
Resolution order: BACKEND_TAG / FRONTEND_TAG > IMAGE_TAG > latest.
Both docker-compose.yml and docker-compose.ghcr.yml now use nested
defaults (`${SIDE_TAG:-${IMAGE_TAG:-latest}}`) so compose config
resolves correctly in all four scenarios (no env / IMAGE_TAG only /
both per-side / mixed). Verified via `docker compose config`.
Docs synced: README.md, docs/README_CN/AR/JA/KO/TH/VI.md, DEVELOPMENT.md,
CONTRIBUTING.md, CLOUD_DEPLOYMENT_{CN,EN}.md, .env.example.
The frontend service now declares both `image:` (default: pull from
GHCR) and `build:` (default context: ./QuantDinger-Vue). Compose
evaluates the build context lazily, so users who only pull never need
the source directory to exist — `docker compose up` still works
unchanged. Developers who want to iterate on Vue source clone the
private repo into the gitignored ./QuantDinger-Vue/ slot and add
--build:
git clone https://github.com/brokermr810/QuantDinger-Vue.git QuantDinger-Vue
docker compose up -d --build
This replaces the docker-compose.frontend-src.yml override approach
proposed earlier — one compose file, one command, no -f stacking.
- docker-compose.yml: dual image+build declaration; FRONTEND_SRC_PATH
overrides the default ./QuantDinger-Vue path.
- .gitignore: add /QuantDinger-Vue/ alongside the existing entries.
- README.md / docs/README_CN.md: rewrite the "Alternative: build from
Vue source" section around the new flow; CN drops the stale
frontend/ entry from the directory tree.
- DEVELOPMENT.md / CONTRIBUTING.md: updated path + cross-reference.
- docs/README_{AR,JA,KO,TH,VI}.md: each quick-start gains a one-line
pointer to the local-build flow linking back to the canonical EN README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend/dist artifacts and old sync/build scripts from this repoQuantDinger-VueBACKEND_TAGandFRONTEND_TAGoverrides in composedocker-compose.ymlWhy
This refactor moves frontend delivery out of the backend repo and into the dedicated Vue repo, which makes releases cleaner and reduces duplicated packaging logic.
It also keeps local development practical by allowing the frontend to be built from source when needed, while preserving the default GHCR-based deployment flow.
Notes
IMAGE_TAGremains the default shared control