Skip to content

fix: delete container - #155

Merged
rodriguecyber merged 1 commit into
developfrom
ft/implement-container-deletion
Aug 28, 2026
Merged

fix: delete container#155
rodriguecyber merged 1 commit into
developfrom
ft/implement-container-deletion

Conversation

@rodriguecyber

Copy link
Copy Markdown
Collaborator

Summary

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Docs
  • Infrastructure / CI
  • Breaking change

Areas touched

  • apps/server (NestJS)
  • apps/web (React / Vite)
  • apps/agent (Go)
  • packages/protocol (shared WebSocket contracts)
  • infrastructure / .github/workflows
  • docs

Related issues

Closes

How to test

Checklist

  • Change is focused and stays within the existing modular monolith boundaries.
  • Ran the relevant checks locally (see below).
  • Updated docs under docs/ if module boundaries or the protocol changed.
  • Added an ADR under docs/decisions/ if this is a larger architectural change.
Local checks
# packages/protocol must be built first — apps/server and apps/web
# import it from its dist output.
npm run build --workspace=@docksight/protocol
npm run test  --workspace=@docksight/protocol

npm run build --workspace=@docksight/server
npm run lint  --workspace=@docksight/server
npm run test  --workspace=@docksight/server

npm run build --workspace=@docksight/web
npm run lint  --workspace=@docksight/web

Protocol changes

  • Updated packages/protocol/src and the fixtures under packages/protocol/fixtures.
  • Server, web, and agent were all updated for the new contract.
  • Noted whether older agents remain compatible.

Screenshots

@rodriguecyber
rodriguecyber merged commit 7506534 into develop Aug 28, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant