fix(office-addin): sync office-addin-excel-customfunctions with upstream - #16717
teamstoolkitworkflowapp[bot] wants to merge 1 commit into
Conversation
…eam OfficeDev/Excel-Custom-Functions
|
@teamstoolkitworkflowapp[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
1 similar comment
|
@teamstoolkitworkflowapp[bot] please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
✅ VscUse Test Plan — All tests passedWhy these tests: The changed TypeScript Office Add-in template has no dedicated listed plan, so the closest VS Code Office Add-in smoke plan was selected. Branch diff: Results: ✅ 1 passed · ❌ 0 failed (of 1 plans) Plans run:
ℹ️ How were these tests selected?GitHub Copilot (GPT-5.6-sol, high reasoning) analysed the PR title, description, and the diff between |
E2E Test Selection — AI SelectedWhy these tests: The .github baseline change is infrastructure-only, and the Office Add-in template does not match any mapped template category or available e2e test case. Cases selected (0): Need to run more tests?Comment on this PR:
Then re-run the workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #16717 +/- ##
==========================================
- Coverage 88.22% 88.21% -0.01%
==========================================
Files 661 661
Lines 36312 36312
Branches 8812 8812
==========================================
- Hits 32035 32034 -1
- Misses 2342 2343 +1
Partials 1935 1935 🚀 New features to boost your workflow:
|
Automated upstream sync:
office-addin-excel-customfunctionsUpstream:
OfficeDev/Excel-Custom-Functions@releaseThis PR was generated from the Office Add-in drift audit. Review carefully — the edits were produced by Copilot from the audit judgment.
It also bumps this template's entry in
.github/office-addin-upstream-baseline.jsonto the synced upstream state, so merging stops the daily check from re-detecting the same drift.Audit judgment
VERDICT: UPDATE NEEDED
src/taskpane/taskpane.tslacks upstream’s null guards forsideload-msg,app-body, andrun; a missing element can abort initialization with a runtimeTypeError.Excel.RequestContextannotation; this is type-safety only and has no runtime effect.src/functions/functions.ts, both HTML files, andtaskpane.cssare behaviorally equivalent; the toolkit’sappPackage/assetsimage path is an intentional layout difference.64358fbcefchanged onlyconvertToSingleHost.js/lockfile handling, notsrc/or declared dependencies. With no newly introduced dependency drift,package.json.tplneeds no update.Upgrade priority: low
Copilot change summary
I’ll apply the audited task-pane-only fix, preserving all template-specific wiring and dependency choices.
The implementation is limited to the audited null safety and type annotation; I’m checking the scoped diff for unintended changes.
Updated
templates/vsc/ts/office-addin-excel-customfunctions/src/taskpane/taskpane.ts:sideload-msg,app-body, andrunto prevent initializationTypeErrors when elements are absent.Excel.RequestContextannotation for type safety.No dependencies, lockfiles, or other template files were changed.
Generated by workflow run: https://github.com/OfficeDev/microsoft-365-agents-toolkit/actions/runs/34320513949