[SeanDuggan]

Fixes #571

[ismisepaul]

that @SeanDuggan , the fix looks good. However, we should probably have an integration test for this.

I reckon put it in src/it/java/servlets/admin/userManagement/ChangeUserPasswordIT.java. Copy the setup from DeletePlayersIT / DowngradeAdminsIT (reset the database in @BeforeAll, Spring mock request and response, TestProperties.verifyTestAdmin plus TestProperties.loginDoPost to get an admin session and CSRF token). Then:

Create a target user with TestProperties.verifyTestUser and get its ID with Getter.getUserIdFromName.
Before calling doPost, attach a small capturing appender to the servlet’s logger and set it to DEBUG. That way the test doesn’t depend on the log config. This needs no new dependency, since log4j-core is already on the classpath:

Assert that the password was really updated (the response contains “password has been updated”). Then assert that no captured message contains the password. Without the first assertion the test could pass just because the servlet failed early.

[SeanDuggan]

Added an integration test for this fix: src/it/java/servlets/admin/userManagement/ChangeUserPasswordIT.java.

It signs in as an admin, creates a target user, and attaches a capturing log4j appender to the ChangeUserPassword logger at DEBUG. Then it resets the user's password through the servlet. It asserts that the response contains "password has been updated", so a servlet that bails out early can't pass. It also asserts that the debug output was captured. Finally it asserts that no captured log message contains the new password.

I checked it both ways locally against MariaDB 12.3. With the fix it passes. With log.debug("newPass = " + newPassword) put back, it fails with "New password was written to the log: newPass = ...". spotless:check passes.