Repository navigation
feat(mobile): add upgrade SQL for existing installs (#894 review) - #1119
Open
SeanDuggan wants to merge 2 commits into
Open
SeanDuggan wants to merge 2 commits into
SeanDuggan wants to merge 2 commits into
Conversation
coreSchema.sql only runs on a fresh setup, so existing databases keep the old mobile module rows: the web /solutionSubmit endpoint rejects the flags the app shows, and the Insecure Communication modules are missing. Add an idempotent script that inserts the two new modules and their cheat sheets and updates the nine existing results, and document it in the 4.0 upgrade guide.
Insecure Communication is deferred to 4.0.1, so the upgrade script no longer inserts its modules or cheat sheets. It now only corrects the flags of existing app modules.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #894. Addresses review point 9: existing installations never re-run
coreSchema.sql, so they keep the old mobile module rows.Problem
/solutionSubmitendpoint rejects the flags the app shows, because the old rows have the wrongmoduleResultorhardcodedKeyfor the nine modules fixed in the Insecure Data Storage, Poor Authentication, Client-Side Injection and Reverse Engineering PRs.Change
updatev4_mobile_modules.sql: inserts the two new modules and their cheat sheets (only if missing) and updates the nine existing results. It is safe to run more than once.docs/upgrading.md: new step 3 explaining how to run it in the Docker installation.Testing
Reverted the nine rows to their
devvalues and deleted the two new modules in a local MariaDB, then ran the script twice. Both runs finished without errors and left the same rows as a fresh install.Depends on the module PRs for the row values, but it can merge independently.