Skip to content

ci: remove broken host-MySQL step from integration-tests - #1115

Closed
HusainMain wants to merge 7 commits into
OWASP:devfrom
HusainMain:fix/ci-mysql-init-d-ubuntu26
Closed

HusainMain wants to merge 7 commits into
OWASP:devfrom
HusainMain:fix/ci-mysql-init-d-ubuntu26

Conversation

@HusainMain

Copy link
Copy Markdown

No description provided.

Husain Bardanwala and others added 5 commits October 29, 2026 20:28
The Start MYSQL Server step runs sudo /etc/init.d/mysql start, but the
Actions runner image migrated to Ubuntu 26.04 which no longer ships
/etc/init.d/mysql. Every PR since Oct 31 (including maintainers' own)
fails at this step.

The workflow already defines a services.mysql container (mariadb:12.3
on port 8888) that the tests connect to via 127.0.0.1:8888, so the
legacy host-level step is redundant.

Found while waiting for PR OWASP#1091 (JDBC driver fix for OWASP#1082) to pass CI.
@HusainMain HusainMain changed the title Fix/ci mysql init d ubuntu26 ci: remove broken host-MySQL step from integration-tests Nov 4, 2026
@HusainMain

Copy link
Copy Markdown
Author

Removes the legacy Start MYSQL Server step (sudo /etc/init.d/mysql start) from the integration-tests job.

Why

The Actions runner image migrated to Ubuntu 26.04, which no longer ships /etc/init.d/mysql. Every PR since Oct 31 fails at this step — including maintainers' own PRs (#1046, #1045).

The job's services.mysql container (mariadb:12.3 on port 8888) already provides MySQL, and tests connect to 127.0.0.1:8888 via Docker port forwarding, so the host-level step is redundant.

Impact

Unblocks integration-tests for all open PRs, including #1091 (JDBC driver fix for #1082).

Testing

  • lint-java, build, unit-tests all pass on this change (workflow YAML only).
  • Confirm the step is redundant: CI's service container already starts mariadb:12.3 health-checked before tests run.

Found while waiting for PR #1091 to pass CI.

Note: I couldn't create a separate GitHub issue for this (automated submissions are rate-limited), so I'm tracking it here as a standalone PR since it's infrastructure, not related to the JDBC fix itself.

@SeanDuggan SeanDuggan self-assigned this Nov 9, 2026
@SeanDuggan

Copy link
Copy Markdown
Member

The Ubuntu 26 fix has since landed on dev through #1116, so this PR now only contains the Setup.java change, which duplicates #1091. #1091 is the dedicated fix for #1082 and already has review history, so I'd suggest closing this one and keeping that.

To get #1091 running again, merge the latest dev into it. It also needs a regression test, or manual test steps in the description (delete database.properties, restart Tomcat, run setup, confirm there is no "No suitable driver").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants