Report where time goes inside the well solves - #7352
Draft
hnil wants to merge 1 commit into
Draft
Conversation
Adds an RAII timing scope to WellInterfaceGeneric and collects it in BlackoilWellModel: well solve time split into assembly and linear solve, well potential solves, control/gaslift/group/network/facility time, and well and well-potential iteration counts. Hidden behind --output-extra-convergence-info=performance, off by default. Timings that nothing fills are not printed, so the report only grows where there is something to show. This is the well half of the instrumentation; the preconditioner, tracer, temperature, property-update and output-write timers follow separately. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
hnil
added
the
manual:enhancement
Closed
Member
|
Is there more work coming here? I only ask because the PR is in a draft state and not marked "ready for review" yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the well half out of #7177, which bska reasonably worried was large enough that the instrumentation would overshadow the logic. 14 files, +615, against 37 files and +839 for the whole thing.
An RAII timing scope in
WellInterfaceGeneric, collected inBlackoilWellModel, giving:Hidden behind
--output-extra-convergence-info=performance, off by default. Every line is printed only when its timer is non-zero, so nothing new appears unless something fills it.Why this half first. It is the part that has already earned its place. On
norne/NORNE_ATW2013_1A_MSWit reports:That the well linear solve is 1.7% of well-solve time is what showed a reuse-the-preconditioner option in #7020 could not pay off, and what identified the right metric for #7051 - neither visible from the existing
Well assemblyline, which lumps assembly and linear solve together.The preconditioner, tracer, temperature, property-update and output-write timers stay in #7177 and follow separately. That also defers the one thing Copilot flagged as a possible runtime regression there - the timing decorator on every preconditioner apply - which is not part of this PR.