Keep the zero-trans overlap and the deck in mechanical runs - #7329
Open
hnil wants to merge 2 commits into
Open
Conversation
hnil
added
the
manual:enhancement
hnil
marked this pull request as ready for review
August 19, 2026 08:23
Mechanics couples cells across zero-transmissibility faces, so the overlap layer must not be pruned by transmissibility when MECH is active -- the same reasoning upstream already applies to thermal runs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Geomechanical runs read fracture seeds and mechanics keywords during the simulation, so the deck must be retained regardless of the general keepKeywords setting. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hnil
force-pushed
the
pr/mech-keep-grid-and-deck
branch
from
August 19, 2026 08:24
58d0373 to
a406c8f
Compare
svenn-t
reviewed
Aug 25, 2026
svenn-t
left a comment
svenn-t
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing overlap cells in geomechanics simulations; it's needed in TPSA as well! Just one question, otherwise it looks good to me.
| keepKeywords, | ||
| // Geomechanics needs the full deck retained (fracture | ||
| // seeds and mech keywords are read during the run). | ||
| keepKeywords || getPropValue<PreTypeTag, Properties::EnableMech>(), |
Contributor
There was a problem hiding this comment.
Do you only need this for fracture simulations or also for other geomechanics purpose? I have not seen the use for this for TPSA yet, so I was wondering if it's necessary to enable for all geomechanics simulators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two one-line conditions, both gated on
runspec.mech():GenericCpGridVanguardstops pruning the overlap layer by transmissibility in mechanical runs. Mechanics couples cells across zero-transmissibility faces, so pruning by transmissibility drops cells the mechanical stencil needs. This is the same reasoning upstream already applies to thermal and temperature runs, added to the same condition.Mainretains the deck when mechanics is enabled, because fracture seeds and mechanics keywords are read during the run rather than only at setup.No effect on a run without
MECH. 8 lines total.