EclWriter: forward dynamically created well connections to EclipseIO - #7328
Open
hnil wants to merge 1 commit into
Open
EclWriter: forward dynamically created well connections to EclipseIO#7328hnil wants to merge 1 commit into
hnil wants to merge 1 commit into
Conversation
hnil
added
the
manual:enhancement
hnil
marked this pull request as ready for review
August 19, 2026 08:23
recordNewDynamicWellConns() passes fracture-created connections (well name + zero-based Cartesian cell ids) to the output layer on the I/O rank, so the summary engine can instantiate connection-level vectors for them (opm-common already provides the receiving API). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hnil
force-pushed
the
pr/eclwriter-dynamic-conns
branch
from
August 19, 2026 08:23
33919b6 to
86f2158
Compare
svenn-t
reviewed
Aug 24, 2026
svenn-t
left a comment
svenn-t
left a comment
Contributor
There was a problem hiding this comment.
I don't have any knowledge about dynamic well connections, so I only have some minor comments.
|
|
||
| void recordNewDynamicWellConns(const DynamicConns& newConns) | ||
| { | ||
| if ((this->rank_ == 0) && (this->eclIO_ != nullptr)) { |
Contributor
There was a problem hiding this comment.
for consistency, use isIORank() instead of this->rank_ == 0
|
|
||
| public: | ||
|
|
||
| using DynamicConns = |
Contributor
There was a problem hiding this comment.
Use out::Summary::DynamicConns instead?
Member
There was a problem hiding this comment.
Use
out::Summary::DynamicConnsinstead?
Maybe. That would require including opm-common's Summary.hpp header here.
Contributor
There was a problem hiding this comment.
Sure, I don't know if that has larger implications, so I'll leave it to you. Just noted the duplication.
Contributor
|
jenkins build this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recordNewDynamicWellConns()hands well name plus zero-based Cartesian cell ids for dynamically created connections to the output layer on the I/O rank, so the summary engine can instantiate connection-level vectors for them.The receiving side already exists in opm-common (
Summary::recordNewDynamicWellConns); this is only the simulator-side forwarding. Nothing upstream calls it yet — it is needed by a fracture model that creates connections during the run, which lives out of tree.12 lines, inert without such a caller.