[DualPorosity] (3/5) Scale fracture well connection factors by porosity - #5318
Draft
arturcastiel wants to merge 3 commits into
Draft
[DualPorosity] (3/5) Scale fracture well connection factors by porosity#5318arturcastiel wants to merge 3 commits into
arturcastiel wants to merge 3 commits into
Conversation
Co-authored-by: AXON <axon@arturcastiel.github.io>
Co-authored-by: AXON <axon@arturcastiel.github.io>
Co-authored-by: AXON <axon@arturcastiel.github.io>
Member
Author
|
jenkins build this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #5317. Its commits are included in this diff and merge first; review only the last commit here.
What this does
Scales well connection factors for wells perforating fracture cells by the fracture porosity,
at the single property choke point, so every connection-factor consumer inherits it.
Why
The effective fracture permeability is scaled by fracture porosity unless the run disables it.
Without this, a well completed in a fracture cell would be given a connection factor computed
from the unscaled permeability — inconsistent with the transmissibilities around it.
Behavior impact
None for flow — the keywords are still rejected. Within opm-common, connection factors for
fracture cells in a dual-continuum deck now carry the scaling.
Testing
Connection-factor ratio cases, including
DUALPERMwithNODPPM.Requirements and limitations
Numerical aquifer cells are deliberately exempt: their properties come from the aquifer
definition, so there is no deck permeability to scale.