Injection network: GNETINJE implies a standard network, and GPRG/GPRW output - #5314
Draft
hnil wants to merge 2 commits into
Draft
Injection network: GNETINJE implies a standard network, and GPRG/GPRW output#5314hnil wants to merge 2 commits into
hnil wants to merge 2 commits into
Conversation
The injection networks (GNETINJE) had no summary output: SummaryConfig collected node names from the production network only, so GPRG/GPRW were dropped as 'not supported in runs without networks', and Summary had no evaluator for them. - data::GroupAndNetworkValues gets gasInj/waterInj node and branch maps, separate from the production maps because a group can be a node of all three networks with different pressures. - SummaryConfig collects the production, gas- and water-injection node names and routes GPRG/GPRW to the injection lists. - Summary evaluates GPRG/GPRW from the new maps. tests/summary_deck.DATA gets a GNETINJE gas and water network (FIELD -> G_2) and test_Summary checks GPRG:G_2/GPRW:G_2 and that GPRG is not created for a group outside the gas network; without this change GPRG:G_2 does not exist. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the opm-simulators injection network work (OPM/opm-simulators#7345 and the WIP draft OPM/opm-simulators#7348 on top of it). Two commits: without the first the network never activates from
GNETINJEalone; without the second the injection network is invisible in the summary, which is why the wrong answers had gone unnoticed.The first commit is atgeirr's.