Track Whether or not Run Supports Solution Tracers - #5302
Conversation
bska
added
the
manual:irrelevant
|
I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #5301. I will keep the PR in a draft state until such time as it is ready for review and merging. |
1f4303b to
dce0942
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds run-level capability flags to TracerConfig to indicate whether solution gas tracers (via DISGAS) and vaporised oil tracers (via VAPOIL) are supported, enabling correct restart array allocation and paving the way for improved input diagnostics.
Changes:
- Introduce
supportsSolutionGasTracer()/supportsVaporisedOilTracer()accessors and persist these flags via serialization and equality. - Populate the new flags from
DISGAS/VAPOILdeck keywords duringTracerConfigconstruction. - Extend parser tests to assert the new support-flag behavior for
DISGASandVAPOIL.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/parser/TracerTests.cpp | Adds assertions and new test cases for solution-tracer support flags. |
| opm/input/eclipse/EclipseState/TracerConfig.hpp | Adds new public accessors and serializes the new support flags. |
| opm/input/eclipse/EclipseState/TracerConfig.cpp | Computes the new support flags from deck keywords and includes them in equality/serialization test object. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Solution gas tracers are supported only if the run itself enables
gas dissolution ("DISGAS" keyword). Similarly, solution oil tracers
are supported only if the run enables oil vaporisation ("VAPOIL"
keyword).
The immediate use case for this is assisting the restart component's
array allocation. Certain arrays must be sized according to the
number of tracer components and we need to know whether or not
solution tracers are active. In the future, these flags will also
permit greater consistency checking and diagnostics for the
simulation input deck.
dce0942 to
8b2faf5
Compare
|
jenkins build this please |
|
I've addressed Copilot's concerns and the build goes through. I'm marking this as "ready for review" now. |
Solution gas tracers are supported only if the run itself enables gas dissolution (
DISGASkeyword). Similarly, solution oil tracers are supported only if the run enables oil vaporisation (VAPOILkeyword).The immediate use case for this is assisting the restart component's array allocation. Certain arrays must be sized according to the number of tracer components and we need to know whether or not solution tracers are active. In the future, these flags will also permit greater consistency checking and diagnostics for the simulation input deck.