Keep MdiWindowController as project file keyword - #14601
Merged
Merged
Conversation
Older versions of ResInsight depend on this keyword to create the window controller for plot windows. 3D views work with both keywords, because Rim3dView creates the controller in its constructor, while plots only get one from the project file. DockWindowController is kept as a read alias so project files written by recent dev builds still load.
jonjenssen
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14600
The MDI to dock widget refactoring renamed the PDM class
RimMdiWindowControllertoRimDockWindowController, and with it the class keyword written to the project file. InCAF_PDM_XML_SOURCE_INITthe first keyword is the one written to file, the remaining ones are read aliases, so dev started writing<WindowController><DockWindowController>.Previous versions of ResInsight have no factory entry for
DockWindowController. WhenPdmChildField::readFieldDatameets an unknown class name it only fails when the field is empty at read time, and this is exactly what separates 3D views from plots:Rim3dViewcreates the controller in its constructor, so the field is already populated. The keyword mismatch only makes the stored fields be skipped, and the view is still displayed.isMdiWindow()is false and no MDI subwindow is ever created, so the plot is silently invisible.This restores
MdiWindowControlleras the keyword written to file and keepsDockWindowControlleras a read alias, so project files written by intermediate dev builds still load. The dropped geometry fields are harmless,RimMdiWindowGeometry::isValid()returns false and the previous version falls back to a default subwindow size, which is the same path the 3D views already take.