Add command runner harness coverage#85
Merged
Merged
Conversation
Add fixture-backed CommandRunner tests for direct command families and expected safety failures, cover the reminders today metadata runner path, and surface the creator line in CLI help. Verification: swift test; swift run icloud-cli --help; swift run icloud-cli drive list --icloud-root Tests/Fixtures/MobileDocuments --format text.
12 tasks
pheidon
approved these changes
Jun 21, 2026
pheidon
left a comment
Contributor
There was a problem hiding this comment.
Approving: the new harness coverage is well-scoped, the help-text attribution test is harmless, and CI Gate is green. I don't see a functional regression in this diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandRunnerharness covering direct CLI command families, cache/watch behavior, and expected sensitive-data failure paths.reminders todaymetadata runner path in the broad inventory command harness.Created by OMT-Global.toicloud-cli --helpand assert it in tests.Governing Issue
No GitHub issue was provided; this PR follows the direct operator request for command test harnesses, local function testing, and creator attribution in
--help.Validation
swift testpassed: 68 testsswift run icloud-cli --helppassed and printsCreated by OMT-Global.swift run icloud-cli drive list --icloud-root Tests/Fixtures/MobileDocuments --format textpassedCI GateNo checks were skipped locally beyond live/private iCloud account probes; the new harness uses repo fixtures and synthetic stores to avoid reading real local account data.
Bootstrap Governance
CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md, anddocs/bootstrap/onboarding.mdwhen applicableFlow Contract
Flow Merge Readiness
Merge Automation
gh pr merge --auto --squash, or the reason it is unavailable/unsafe is noted belowAuto-merge has not been enabled yet; this PR needs live required-check and review-state evaluation after creation.
Notes
--confirm-sensitive.