Skip to content

Add command runner harness coverage#85

Merged
daedalus-omt merged 1 commit into
mainfrom
codex/test-harness-help-creator-clean
Jun 21, 2026
Merged

Add command runner harness coverage#85
daedalus-omt merged 1 commit into
mainfrom
codex/test-harness-help-creator-clean

Conversation

@jmcte

@jmcte jmcte commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a fixture-backed CommandRunner harness covering direct CLI command families, cache/watch behavior, and expected sensitive-data failure paths.
  • Cover the reminders today metadata runner path in the broad inventory command harness.
  • Add Created by OMT-Global. to icloud-cli --help and assert it in tests.

Governing Issue

No GitHub issue was provided; this PR follows the direct operator request for command test harnesses, local function testing, and creator attribution in --help.

Validation

  • Relevant local checks passed
    • swift test passed: 68 tests
    • swift run icloud-cli --help passed and prints Created by OMT-Global.
    • swift run icloud-cli drive list --icloud-root Tests/Fixtures/MobileDocuments --format text passed
  • Required PR checks are expected to satisfy CI Gate
  • Skipped checks are explained below

No checks were skipped locally beyond live/private iCloud account probes; the new harness uses repo fixtures and synthetic stores to avoid reading real local account data.

Bootstrap Governance

  • Changes are scoped to the direct operator request
  • Contributor or PR guidance changes are reflected in CONTRIBUTING.md, .github/PULL_REQUEST_TEMPLATE.md, and docs/bootstrap/onboarding.md when applicable
  • PR author enabled auto-merge where GitHub allows it, or GitHub plan-limit evidence/unavailable reason is recorded and the fallback merge-readiness policy applies
  • No real secrets, runtime auth, or machine-local env files are committed

Flow Contract

  • Owner lane: operator-requested CLI quality
  • Repair owner: Codex
  • Autonomy class: scoped implementation with local validation
  • Risk class: low; tests and help text only

Flow Merge Readiness

  • Every blocker has a next actor and next action
  • No active blocking requested changes remain
  • Non-author approval is present when required
  • PR author enabled auto-merge where GitHub allows it, or recorded why it is unavailable/unsafe

Merge Automation

  • PR author enabled auto-merge with gh pr merge --auto --squash, or the reason it is unavailable/unsafe is noted below

Auto-merge has not been enabled yet; this PR needs live required-check and review-state evaluation after creation.

Notes

  • The direct command harness intentionally verifies safety failures for sensitive commands without --confirm-sensitive.
  • Fixture-backed local execution avoids touching real iCloud, Safari, Messages, Contacts, Photos, or Wallet data.

Add fixture-backed CommandRunner tests for direct command families and expected safety failures, cover the reminders today metadata runner path, and surface the creator line in CLI help.

Verification: swift test; swift run icloud-cli --help; swift run icloud-cli drive list --icloud-root Tests/Fixtures/MobileDocuments --format text.
@jmcte jmcte requested a review from pheidon as a code owner June 21, 2026 07:41
@jmcte jmcte mentioned this pull request Jun 21, 2026
12 tasks

@pheidon pheidon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving: the new harness coverage is well-scoped, the help-text attribution test is harmless, and CI Gate is green. I don't see a functional regression in this diff.

@daedalus-omt daedalus-omt merged commit a60604a into main Jun 21, 2026
1 check passed
@daedalus-omt daedalus-omt deleted the codex/test-harness-help-creator-clean branch June 21, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants