[19.0][MIG] agreement_account: Migration to 19.0

[SyncMasta]

Summary

Migrates agreement_account from 18.0 to 19.0. Marked as Draft so OCA CI can validate it without adding review-queue pressure while #111 (agreement_legal) is still pending.

Two commits:

1. init migration — copies the 18.0 source verbatim with the manifest bumped to 19.0.1.0.0 and an empty migrations/19.0.1.0.0/pre-migration.py placeholder.
2. 19.0 API + prettier format — applies the only 19.0 breaking change in this module (read_group → _read_group at 2 sites in _compute_invoice_count) plus prettier-XML normalisation across the view files.

Net change: 1 production code file (models/agreement.py), 2 view files reformatted.

19.0 API adaptation

read_group was removed in 19.0; replaced both call sites with _read_group using the new groupby= / aggregates= keyword form, which returns recordset tuples directly:

# 18.0
rg = aio.read_group(domain, ["agreement_id"], ["agreement_id"])
data = {x["agreement_id"][0]: x["agreement_id_count"] for x in rg}

# 19.0
rg = aio._read_group(domain, groupby=["agreement_id"], aggregates=["__count"])
data = {agreement.id: count for agreement, count in rg}

The change is local to _compute_invoice_count on the inherited agreement model. No other 19.0-API touches were needed (no _() translation calls, no res.groups records, no multi-_inherit, no target='inline' actions, no lambda-default fields, no wizard/view ordering issues — all the categories that bit us in #111).

Dependencies

• [19.0][MIG] agreement_legal: Migration to 19.0 #111

Test plan

• OCA CI: pre-commit, test with Odoo, test with OCB, codecov
• Reviewers: confirm Smart-Buttons (Invoices, Vendor Bills) on the agreement form still render correct counts under the new _read_group mapping

Related

• Module-tree status on 19.0:
  • agreement ✅ ([19.0][MIG] agreement: Migration to 19.0 #99)
  • agreement_rebate* ✅ ([19.0][MIG] agreement_rebate: Migration to 19.0 #108, [19.0][MIG] agreement_rebate_partner_company_group: Migration to 19.0 #110)
  • agreement_sale 🟡 ([19.0][MIG] agreement_sale: Migration to 19.0 #100, open, all checks green)
  • agreement_legal 🟡 ([19.0][MIG] agreement_legal: Migration to 19.0 #111, open, all checks green — same author)
  • agreement_account 🟡 (this PR)

🤖 Generated with Claude Code

[max3903]

/ocabot migration agreement_account

[max3903]

Review summary

Solid 19.0 migration overall — read_group → _read_group, menu rename to account.menu_finance_configuration, and the search xpath fix all look correct. CI is green.

A few items should be cleaned up before merge:

Requested changes

1. Remove empty migrations/19.0.1.0.0/pre-migration.py
   OCA’s 19.0 guide asks to drop migrations/ when there is no schema work. This file is only a docstring (no migrate(cr, version)). Prefer deleting the folder entirely.

2. Strengthen test_compute_invoice_count
   The test never creates invoices, so it does not protect the _read_group mapping — the only real 19.0 API change. Please create at least one customer invoice and one vendor bill linked to an agreement and assert the counts.

3. setUpClass(self) → setUpClass(cls)
   Works by accident on a classmethod, but it should use the conventional cls parameter.

Non-blocking / nit

• PR body: this module does not depend on agreement_legal (#111). Depends are only agreement + account (agreement is already on 19.0). Also the body still says “Draft” / “two commits” while the PR is open with 4 commits.
• Supplier form xpath //page/group/group/field[@name='company_id'] is fragile on 19.0 (company_id lives in accounting_info_group and is multi-company). CI load passed; a more precise xpath would be safer if you touch that view again.

Thanks for the migration!