For #540 - Refactor http code for reuse#541
Merged
lars-t-hansen merged 10 commits intomainfrom Apr 14, 2026
Merged
Conversation
lars-t-hansen
commented
Apr 14, 2026
lars-t-hansen
commented
Apr 14, 2026
lars-t-hansen
commented
Apr 14, 2026
lars-t-hansen
commented
Apr 14, 2026
lars-t-hansen
commented
Apr 14, 2026
Collaborator
Author
|
Despite --silent and --retry, curl spams a lot on stderr when it can't contact the server. Sonar handles this but not very gracefully, it will dump a debug message every time it can read something, it does not wait for a complete error message, so sometimes there can be lots of debug spew for what's one line from curl. This is more or less by design since not all programs write complete lines but since it's curl I guess we could assume there will be a newline eventually. Since the problem is not new I'll file a followup, not fix it in this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits a bunch of logic out of the Kafka code into a "background uploader" idea and a "http post" idea. Functionality-wise this should represent no change. I will need to test some more before landing but otherwise this is done. Once it's done, #540 is easy.