Skip to content

For #540 - Refactor http code for reuse#541

Merged
lars-t-hansen merged 10 commits intomainfrom
larstha-540-background-sender
Apr 14, 2026
Merged

For #540 - Refactor http code for reuse#541
lars-t-hansen merged 10 commits intomainfrom
larstha-540-background-sender

Conversation

@lars-t-hansen
Copy link
Copy Markdown
Collaborator

This splits a bunch of logic out of the Kafka code into a "background uploader" idea and a "http post" idea. Functionality-wise this should represent no change. I will need to test some more before landing but otherwise this is done. Once it's done, #540 is easy.

Comment thread src/datasink/background.rs Outdated
Comment thread src/datasink/background.rs Outdated
Comment thread src/datasink/background.rs Outdated
Comment thread src/datasink/kafka.rs Outdated
Comment thread src/datasink/kafka.rs Outdated
@lars-t-hansen
Copy link
Copy Markdown
Collaborator Author

Despite --silent and --retry, curl spams a lot on stderr when it can't contact the server. Sonar handles this but not very gracefully, it will dump a debug message every time it can read something, it does not wait for a complete error message, so sometimes there can be lots of debug spew for what's one line from curl. This is more or less by design since not all programs write complete lines but since it's curl I guess we could assume there will be a newline eventually. Since the problem is not new I'll file a followup, not fix it in this patch.

@lars-t-hansen lars-t-hansen merged commit 929d11e into main Apr 14, 2026
5 checks passed
@lars-t-hansen lars-t-hansen deleted the larstha-540-background-sender branch April 14, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant