Repository navigation
ci(release): release slang from slang/X.Y.Z tags - #795
Merged
Merged
Conversation
Coverage Summary
|
nebasuke
added this pull request to stack #788
October 4, 2026 14:44
nebasuke
force-pushed
the
slang-release-workflow
branch
from
October 4, 2026 14:59
bcb86be to
976baf0
Compare
nebasuke
force-pushed
the
slang-release-workflow
branch
from
October 4, 2026 18:24
976baf0 to
5e5d988
Compare
nebasuke
force-pushed
the
slang-release-workflow
branch
from
October 5, 2026 12:44
5e5d988 to
d9d9b50
Compare
nebasuke
force-pushed
the
slang-release-workflow
branch
3 times, most recently
from
October 7, 2026 10:34
926622c to
d9cdbd4
Compare
nebasuke
marked this pull request as ready for review
October 7, 2026 11:51
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Installer path handling, piped argument documentation, and release-rerun changelog selection need correction.
3 open findings
What changed in this PR
Adds a dedicated Slang release channel using slang/X.Y.Z tags while preserving solx as the latest release.
Changes:
- Adds the Slang installer and installation documentation.
- Updates release automation, asset naming, changelogs, and verification.
- Deploys versioned Slang documentation.
| File | Description |
|---|---|
install-slang |
Installs Slang releases by version or latest tag. |
docs/src/user-guide/01-installation.md |
Documents Slang installation and release assets. |
.github/workflows/release.yaml |
Publishes Slang-tagged releases and deploys documentation. |
.github/workflows/deploy-docs.yaml |
Accepts a version from reusable workflow callers. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
hedgar2017
approved these changes
Oct 8, 2026
hedgar2017
left a comment
hedgar2017
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just take a look at the Copilot comments.
Curious, how are we going to handle the repo rename?
The repository publishes both slang and solx 0.1.x, so slang releases take their own tag namespace: a bare X.Y.Z tag on main no longer publishes anything, and the tag workflow on main-solc keeps releasing solx. The `latest` release stays on solx 0.1.x, which install-solx, the compile benchmark and the releases mirror read; install-slang finds the newest slang/ release instead. The docs deploy for a slang release moves the site's latest link to Slang. The previous-release lookup falls back to `latest` only when no slang release exists, so a failed API call fails the step instead of building the changelog from the wrong base.
The page said Slang had no release and sent readers to install-solx, and the docs only deploy on a slang/ tag, so the first release would have published that as the site's latest page.
hedgar2017
force-pushed
the
slang-release-workflow
branch
from
October 8, 2026 10:40
d9cdbd4 to
bf65445
Compare
A rerun after the tag is published found its own release as the newest slang one, so the changelog ran from the tag to itself and replaced the release body with an empty one.
…xists The installers skipped the profile edit whenever any binary of that name was on PATH, so an older build elsewhere kept running. They now check for the directory itself and warn when an earlier PATH entry shadows it.
Options appended after `| bash` go to bash, not the script.
Member
Author
Thanks, addressed! Repo rename -> not sure yet to be honest. I don't have strong feelings about this, nor do I think we are in a rush to do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intermediate step to start publish slang via pushing
slang/x.y.ztags. Latest will stay atsolx 0.1.8until we are happy to change this.Claude summary
Releases slang from
slang/X.Y.Ztags, next to the solx 0.1.x releases in the same repository.slang/X.Y.Ztag publishesslang-<platform>-vX.Y.Zassets after approval, with a changelog from the previous slang release (solx 0.1.8 for the first one).latestrelease stays on solx 0.1.x, andinstall-slanginstalls the newest slang release, or the one given with--version.install-solxis unchanged and still installs solx 0.1.x, the latest or one given with--version, since slang releases never takelatest.install-slang.X.Y.Ztag onmainpublishes nothing.