github: use libgit2 transport for ref resolution#15470
Open
domenkozar wants to merge 1 commit intoNixOS:masterfrom
Open
github: use libgit2 transport for ref resolution#15470domenkozar wants to merge 1 commit intoNixOS:masterfrom
domenkozar wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
Bot
added
the
fetching
domenkozar
force-pushed
the
github-rate-limits
branch
from
42e0d86 to
2fa2411
Compare
domenkozar
added a commit
to cachix/devenv
that referenced
this pull request
Mar 14, 2026
Upstreamed as NixOS/nix#15470. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
domenkozar
force-pushed
the
github-rate-limits
branch
2 times, most recently
from
0fd340e to
3492d21
Compare
xokdvium
reviewed
Mar 18, 2026
domenkozar
force-pushed
the
github-rate-limits
branch
from
3492d21 to
d61b4f2
Compare
Eveeifyeve
approved these changes
Mar 18, 2026
Member
|
I don't see any issues with this, I could be missing something. |
Member
Author
|
@xokdvium let's merge this one as well? Looking forward not to hammer github http api |
xokdvium
reviewed
Mar 25, 2026
xokdvium
reviewed
Mar 25, 2026
domenkozar
force-pushed
the
github-rate-limits
branch
3 times, most recently
from
1ae0dfa to
c4e92a7
Compare
Ericson2314
reviewed
Mar 26, 2026
Ericson2314
reviewed
Mar 26, 2026
domenkozar
force-pushed
the
github-rate-limits
branch
from
c4e92a7 to
6919a7d
Compare
Use libgit2's high level remote API (git_remote_create_detached, git_remote_connect, git_remote_ls) instead of manually downloading and parsing the smart HTTP pkt-line format. This delegates protocol handling to libgit2 while keeping auth via custom HTTP headers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
domenkozar
force-pushed
the
github-rate-limits
branch
from
6919a7d to
250b1ce
Compare
xokdvium
reviewed
Mar 29, 2026
| git_remote_callbacks callbacks = GIT_REMOTE_CALLBACKS_INIT; | ||
| callbacks.payload = const_cast<void *>(static_cast<const void *>(&token)); | ||
| callbacks.credentials = | ||
| [](git_credential ** out, const char *, const char *, unsigned int allowed_types, void * payload) -> int { |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| [](git_credential ** out, const char *, const char *, unsigned int allowed_types, void * payload) -> int { | |
| [](git_credential ** out, const char *, const char *, unsigned int allowedTypes, void * payload) -> int { |
| auto * tok = static_cast<const std::string *>(payload); | ||
| if (tok->empty()) | ||
| return GIT_PASSTHROUGH; | ||
| if (allowed_types & GIT_CREDENTIAL_USERPASS_PLAINTEXT) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (allowed_types & GIT_CREDENTIAL_USERPASS_PLAINTEXT) | |
| if (allowedTypes & GIT_CREDENTIAL_USERPASS_PLAINTEXT) |
| if (git_remote_connect(remote.get(), GIT_DIRECTION_FETCH, &callbacks, nullptr, nullptr)) | ||
| throw GitError("connecting to remote '%s'", url); | ||
|
|
||
| const git_remote_head ** refs; |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| const git_remote_head ** refs; | |
| const gitRemoteHead ** refs; |
| store.requireStoreObjectAccessor(downloadResult.storePath)->readFile(CanonPath::root)); | ||
| auto owner = getOwner(input); | ||
| auto repo = getRepo(input); | ||
| auto url = fmt("https://%s/%s/%s.git", host, owner, repo); |
Contributor
There was a problem hiding this comment.
Constructing the URL this way is fine, since github doesn't allow anything that would need percent encoding in the repo/owner name. Just a note to readers.
|
|
||
| Headers headers = makeHeadersWithAuthTokens(settings, host, input); | ||
|
|
||
| auto downloadResult = downloadFile(store, settings, url, "source", headers); |
Contributor
There was a problem hiding this comment.
One thing to note here is that we lose the caching that downloadFile does. Any way to recover it? Is this a concern at all?
Contributor
There was a problem hiding this comment.
This is probably the more concerning question I have. Everything else is mostly noise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve branch/tag names to commit SHAs via the git HTTP protocol (/info/refs endpoint) instead of the GitHub REST API. This is the same approach already used by SourceHut and avoids API rate limits.