Fix modal detection, light mode contrast, notification validation... - #990
Merged
robertocarlous merged 1 commit intoSep 26, 2026
Conversation
…d toast memoization Closes Neurowealth#912, Neurowealth#911, Neurowealth#910, Neurowealth#908 - Fix WalletConnectButton modal-detection to check descendants instead of only direct nodes, ensuring modal detection works when the matching class is on a descendant element - Add test file for WalletConnectButton component to cover modal detection logic - Fix unreadable search text in CommandPaletteDialog light mode by adding appropriate light-mode text-color variants to input, list items, and icons - Add shape validation to useNotifications localStorage read with per-item validation following the guard pattern used in onboarding-state.ts - Memoize ToastProvider's context value with useMemo and wrap functions in useCallback to prevent unnecessary re-renders of all useToast consumers
|
@johnsmccain Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the following Round-6 audit issues:
WalletConnectButtonto detect nested wallet modal elements and add component tests.CommandPaletteDialog.localStorage.ToastProvidercontext value to prevent unnecessary re-renders.Verification
Scope
Changes are limited to the affected files with no unrelated behavior changes.
Closes #912
Closes #911
Closes #910
Closes #908