Skip to content

Make waveform units configurable #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rly merged 1 commit into from
Jul 31, 2026
+8 −6
Merged

Make waveform units configurable #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions core/nwb.misc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,8 @@ groups:
required: false
- name: unit
dtype: text
value: volts
doc: Unit of measurement. This value is fixed to 'volts'.
default_value: volts
doc: Unit of measurement. The default value is 'volts'.
required: false
- name: waveform_sd
neurodata_type_inc: VectorData
Expand All @@ -295,8 +295,8 @@ groups:
required: false
- name: unit
dtype: text
value: volts
doc: Unit of measurement. This value is fixed to 'volts'.
default_value: volts
doc: Unit of measurement. The default value is 'volts'.
required: false
- name: waveforms
neurodata_type_inc: VectorData
Expand Down Expand Up @@ -332,8 +332,8 @@ groups:
required: false
- name: unit
dtype: text
value: volts
doc: Unit of measurement. This value is fixed to 'volts'.
default_value: volts
doc: Unit of measurement. The default value is 'volts'.
required: false
- name: waveforms_index
neurodata_type_inc: VectorIndex
Expand Down
2 changes: 2 additions & 0 deletions docs/format/source/format_release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Release Notes

Bug fixes
^^^^^^^^^
- ``Units.waveform_mean``, ``Units.waveform_sd``, and ``Units.waveforms`` now accept a unit other than the default
value, ``volts``.
- Fixed copy-paste error in ``VoltageClampSeries.capacitance_slow`` unit attribute doc, which incorrectly
referenced ``capacitance_fast``.
- Fixed ``IntervalSeries.data`` resolution and unit attribute docs, which were verbatim copy-paste from
Expand Down
Loading