Conversation
Allow each runner to optionally specify its own url and token_file, enabling a single outrunner instance to serve multiple repositories. Runners without overrides fall back to the global config values. Scaleset clients are deduplicated by (url, token) pair so runners targeting the same repo share a single client. Validation ensures every runner has a reachable URL (global or local).
Remove URL validation from LoadConfig — it broke --url-only users since LoadConfig runs before CLI flags are considered. URL is now validated at resolve time in main.go. Fix misleading test name "flag beats everything" → "runner URL beats flag" to match what the test actually asserts. Sort runner names before iterating config.Runners map for deterministic startup order and log output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urlandtoken_filefields to per-runner config, enabling a single outrunner instance to serve multiple repositories(url, token)pair — runners targeting the same repo share a single clientTest plan