Repository navigation
Read default registry configuration at construction - #96
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registry()currently uses aConfig()created when the module is imported. SettingSPECTATOR_OUTPUT_LOCATIONor process tags after import therefore has no effect on a new default registry. For example, selectingmemorystill produces a socket writer.Create the default configuration when the registry is constructed. Explicit configuration objects retain their existing behavior. Two regression tests cover environment changes after import and between registry instances; both fail before the fix.
Validation: all 122 tests pass on Linux, including UDP and Unix socket tests. Pylint rates the changed files 10/10, and mypy with the Linux platform passes for all 56 source files. The test run reports existing resource warnings for a file and socket.