feat: seed obscured keypoints from NaN detections + GUI polish - #18
Merged
Conversation
Continues the obscure-from-nan work on this branch: - EditorState.from_result seeds the per-view obscured mask from NaN 2D detections, so a view that didn't see a keypoint starts dropped from triangulation (following the reprojection) until the operator drags it in. - Add a whole-frame reset (Corrections.clear_frame / EditorState.reset_frame), wired to a Reset > "Whole frame" button and a reset_frame edit message. - Shorten the tab-close disconnect grace to 0.5s (localhost reconnect is fast) and log reconnects / cancelled shutdowns. - GUI polish: control tooltips, "Camera rig" naming, and a Keypoints reference link that opens the docs viewer in a new tab. Also fixes a separate annoyance: when auto-opening the browser, silence the launcher's stdio. The launcher webbrowser shells out to may be an external wrapper that inherits our stderr -- e.g. VS Code's browser.sh runs Node, which prints a `url.parse()` deprecation warning -- leaking into the otherwise clean CLI output. The browser child has no use for our stdio. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the obscure-from-nan work on this branch:
Also fixes a separate annoyance: when auto-opening the browser, silence the launcher's stdio. The launcher webbrowser shells out to may be an external wrapper that inherits our stderr -- e.g. VS Code's browser.sh runs Node, which prints a
url.parse()deprecation warning -- leaking into the otherwise clean CLI output. The browser child has no use for our stdio.