Skip to content

Refactor/cxx20 modernization #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajaypanyala merged 22 commits into from
Jul 5, 2026
Merged

Refactor/cxx20 modernization #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
18f02de
refactor(cxx20): modernize block_span, strong_num, errors, boundvec, …
abagusetty Mar 25, 2026
cac55d7
docs: restore Doxygen API comments removed in cxx20 refactor
abagusetty Mar 25, 2026
324c4a9
fix: subtle C++ correctness issues in lru_cache, perm, boundvec, types
abagusetty Mar 25, 2026
3ac53c2
fix: tensor contraction correctness and memory management bugs
abagusetty Mar 25, 2026
7f326ed
perf: C++20 memory and contraction performance optimizations
abagusetty Mar 25, 2026
1703270
fix: three correctness bugs introduced in perf commit (7f326ed)
abagusetty Mar 25, 2026
142519f
Merge branch 'NWChemEx:main' into refactor/cxx20-modernization
abagusetty Jul 1, 2026
263292e
fix: correctness regressions + pre-existing bugs in cxx20 refactor
Jul 3, 2026
ce2ae23
fix: restore StrongNum implicit conversions and EXPECTS pointer support
Jul 3, 2026
dcb26e3
fix: complete TiledIndexSpace in index_space_interface.hpp
Jul 3, 2026
82f19ec
refactor: C++20 LOC reduction and design cleanup in op/infra headers
Jul 3, 2026
431f83a
few new tests
Jul 3, 2026
c5addcb
cleanup a test
Jul 3, 2026
b3bb886
fix a few warnings
Jul 3, 2026
264af02
Merge branch 'NWChemEx:main' into refactor/cxx20-modernization
ajaypanyala Jul 3, 2026
ac460f0
C++20 fixes for clang builds
ajaypanyala Jul 3, 2026
391ccd0
Merge branch 'NWChemEx:main' into refactor/cxx20-modernization
ajaypanyala Jul 3, 2026
cc8a1a3
refactor: adopt modern C++20 idioms and RAII in core headers
Jul 3, 2026
ebe71dd
sync with upstream
ajaypanyala Jul 3, 2026
b1d2e3c
minor
ajaypanyala Jul 3, 2026
e30e710
add deleted op_cost, op_executor_analysis files
ajaypanyala Jul 5, 2026
a946ec8
remove redundant logic from CMakeLists.txt
ajaypanyala Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions cmake/check_user_env.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,25 +45,15 @@ if(DEFINED GA_RUNTIME)
endif()
endif()

check_compiler_version(C Clang 9)
check_compiler_version(CXX Clang 9)
check_compiler_version(C Clang 18)
check_compiler_version(CXX Clang 18)

check_compiler_version(C AppleClang 15)
check_compiler_version(CXX AppleClang 15)
check_compiler_version(C AppleClang 19)
check_compiler_version(CXX AppleClang 19)

check_compiler_version(C GNU 9.1)
check_compiler_version(CXX GNU 9.1)
check_compiler_version(Fortran GNU 9.1)

#TODO:Check for GCC>=9 compatibility
# check_compiler_version(C Intel 19)
# check_compiler_version(CXX Intel 19)
# check_compiler_version(Fortran Intel 19)

#TODO:Check for GCC>=9 compatibility
check_compiler_version(C PGI 20)
check_compiler_version(CXX PGI 20)
check_compiler_version(Fortran PGI 20)
check_compiler_version(C GNU 14.1)
check_compiler_version(CXX GNU 14.1)
check_compiler_version(Fortran GNU 14.1)

find_package(MPI REQUIRED)

Expand Down Expand Up @@ -97,7 +87,7 @@ if(${PROJECT_NAME}_ENABLE_CUDA)
message(FATAL_ERROR "CUDA Toolkit not found.")
endif()

set(_CUDA_MIN "11.7")
set(_CUDA_MIN "12.8")
if(CMAKE_CUDA_COMPILER_VERSION VERSION_LESS ${_CUDA_MIN})
message(FATAL_ERROR "CUDA version provided \
(${CMAKE_CUDA_COMPILER_VERSION}) \
Expand Down
2 changes: 1 addition & 1 deletion src/tamm/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ set(TAMM_INCLUDES
eigen_includes.hpp
runtime_engine.hpp
block_buffer.hpp
block_scratch.hpp
lru_cache.hpp
kernels/assign.hpp
kernels/multiply.hpp
Expand All @@ -92,7 +93,6 @@ set(TAMM_INCLUDES
tensor_variant.hpp
op_executor.hpp
symbol.hpp
op_cost.hpp
block_operations.hpp
setop.hpp
scanop.hpp
Expand Down
Loading
Loading