Change dependency resolution order - #84
Merged
Merged
Conversation
jwaldrop107
approved these changes
Sep 10, 2026
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long story short, when repo
Xis the top-level repo (i.e., the repo we're calling thecmakecommand on) we always want to build that repo and we never want to use a packaged version. This refactor ensures that our dependency function always ignores requests to get the top-level repo. It also builds in that settingFETCHCONTENT_SOURCE_DIR_Xshould take precedence over finding a wheel.