Fix missing BUILD_INTERFACE include dirs on in-tree libxc's xc target - #83
Merged
Merged
Conversation
libxc's own CMakeLists only adds its generated-header directories (build-tree xc.h, xc_version.h, config.h) via directory-scoped include_directories(), and only publishes an INSTALL_INTERFACE on the xc target -- fine for an installed Libxc::xc, but leaves the in-tree FetchContent target with no build-tree include path for any consumer outside libxc's own CMakeLists. Reproduced as SCF PR #71's CI failure ("xc.h: file not found") on a from-scratch build with no pre-existing libxc install to mask it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jwaldrop107
approved these changes
Sep 4, 2026
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xc.h,xc_version.h,config.h) onto its directory-scopedinclude_directories(), and only publishes anINSTALL_INTERFACEon thexctarget -- fine for afind_package(Libxc CONFIG)-importedLibxc::xc, but the in-tree FetchContentxctarget carries no build-tree include path for any consumer outside libxc's own CMakeLists.xc.h: file not found) on a from-scratch build with no pre-existing libxc install anywhere to mask it -- this had originally looked like a stale GitHub Actions cache issue, but persisted after clearing the cache, pointing to this underlying bug instead.BUILD_INTERFACEinclude dirs on thexctarget, matching libxc's owninclude_directories()call exactly.Test plan
-DCMAKE_DISABLE_FIND_PACKAGE_Libxc=ONto force the in-tree path, editable-installed NWXCMake picking up this fix) --cxx/src/scf/xc/libxc/libxc.cppcompiled andlibscf.dyliblinked successfully.🤖 Generated with Claude Code