fix: address review feedback on config-manager symlink handling - #1995
Merged
abrarshivani merged 1 commit intoSep 1, 2026
Merged
Conversation
tariq1890
approved these changes
Sep 1, 2026
tariq1890
left a comment
tariq1890
left a comment
Contributor
There was a problem hiding this comment.
Thanks @abrarshivani !
Contributor
|
Please squash the commit history as well |
Wrap errors with %w instead of %v/%s so callers can unwrap them, and drop the redundant quoting since logs are already emitted in JSON. Split TestUpdateSymlinkDanglingDestination into independent subtests that each set up their own state via a shared fixture helper, so either case passes when run in isolation rather than depending on execution order. Signed-off-by: Abrar Shivani <ashivani@nvidia.com>
abrarshivani
force-pushed
the
fix/config-manager-symlink-review-feedback
branch
from
September 1, 2026 21:29
7a4c210 to
4855607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1982, addressing review feedback from @tariq1890 that came in after the PR had already merged.
%winstead of%v, and drop the redundant quoting around the destination path since these logs are already emitted in JSON.TestUpdateSymlinkDanglingDestinationinto two independent subtests. Previously the second subtest relied on state left behind by the first, so it failed when run in isolation (e.g. via-run).I left the
!os.IsNotExist(err)check on theos.Removecall as is: it guards a different error value from a different syscall than the earlieros.Readlinkcheck, so it isn't actually redundant, it's the standard idiom for tolerating a concurrent removal between the two calls.