Conversation
Move cuVS's direct third-party Git source declarations into a project CPM metadata catalog and resolve them through rapids_cpm_package_info. Pin each catalog Git source to its resolved commit, retaining the prior tag or branch as ignored git_tag_alias metadata. This lets parent builds replace sources through RAPIDS_CMAKE_CPM_OVERRIDE_VERSION_FILE without patching cuVS sources while preserving auditable default pins. Cover library and example CMake getters, and enforce the source-metadata rule in the existing GitHub Actions checks job rather than local pre-commit. Created with Codex (GPT-5).
Use the Artifactory PyPI remote for dependency resolution and fetch spdx-license-builder from the internal GitLab mirror at the RAPIDS branch. Created with Codex (GPT-5).
Member
Author
|
@robertmaynard reached out to me and told me that this is not the right approach. We have an internal fork of rapids-cmake that is intended to override all of these, but it isn't specified as an override, and thus it doesn't affect these cmake-defined URLs. The right way is to specify the replacements as overrides. Per Robert's advice, I am closing this PR. If the cudf team wants it anyway, feel free to say so or reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintaining the standalone cuvs build internally has highlighted a few pain points. One of them is hard-coded repos in cmake getter code. rapids-cmake has a nice override mechanism, but we can't use that mechanism when the URLs are defined in the cmake code instead of going through rapids-cmake.
This PR moves cuvs's direct third-party Git source declarations into a project CPM metadata catalog and resolves them through rapids_cpm_package_info. This lets parent builds replace sources through RAPIDS_CMAKE_CPM_OVERRIDE_VERSION_FILE without patching cuvs sources, while preserving cuvs's default pins. It also nicely consolidates all of the versions in one place. This PR adds a pre-commit guard to prevent future direct Git declarations in thirdparty getters.