fix(installer): name DGX Spark express sandbox

[sandl99]

Summary

DGX Spark express install now defaults the sandbox name to my-spark-assistant unless NEMOCLAW_SANDBOX_NAME is already set. This matches the DGX Spark express-install
expectation while preserving existing defaults for DGX Station, Windows WSL, and normal onboarding.

Manual test

  local-sdang@spark-b29e:~/NemoClaw$ nemoclaw status

  Sandboxes:
    my-spark-assistant * (qwen3.6:35b) :18789
      Inference: ollama-local / qwen3.6:35b
      Connected: no

Related Issue

Fixes #3945

Changes

• Set NEMOCLAW_SANDBOX_NAME=my-spark-assistant for DGX Spark express install when no sandbox name is preconfigured.
• Show the resolved sandbox name in the express-install summary.
• Update installer coverage for the DGX Spark express sandbox name.
• Document the DGX Spark express-install sandbox default in the quickstart.

Type of Change

• Code change with doc updates

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: San Dang sdang@nvidia.com

[coderabbitai]

📝 Walkthrough

Walkthrough

Express install on DGX Spark now reports and defaults the sandbox name to my-spark-assistant. The install script computes platform-specific sandbox summaries and exports the DGX Spark default; tests validate the output format; quickstart docs explain the override behavior.

Changes

Express Install Sandbox Naming

Layer / File(s)	Summary
Sandbox name reporting in install script scripts/install.sh	describe_express_install() declares sandbox_summary per platform (DGX Spark, DGX Station, Windows WSL, default), prints Sandbox name: ... output, and exports NEMOCLAW_SANDBOX_NAME=my-spark-assistant for DGX Spark when unset.
Test assertions for sandbox name output test/install-preflight.test.ts	Test script's RESULT ... line expanded to include NEMOCLAW_SANDBOX_NAME as SANDBOX=.... Test assertions strengthened to expect Sandbox name: ... output and require resolved SANDBOX value in RESULT NON_INTERACTIVE=... across TTY, WSL, and non-TTY scenarios.
Quickstart documentation update docs/get-started/quickstart.mdx	Adds DGX Spark express install note: sandbox name defaults to my-spark-assistant unless NEMOCLAW_SANDBOX_NAME is already set.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

documentation

Suggested reviewers

• ericksoa
• cv

Poem

A spark ignites with sandbox name so fine,
my-spark-assistant shines on the line,
Tests hop and verify, docs light the way,
Express install greets the DGX with flair today! 🐰✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR addresses the sandbox naming requirement from issue #3945, but does not implement other key requirements: Brave Web Search prompt, DNS tooling, or warm-up step.	Complete remaining issue #3945 requirements: add Brave Web Search opt-in prompt for express install, ensure nslookup is available in sandbox, and surface warm-up step after sandbox creation.
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: setting DGX Spark express sandbox default name, which aligns with the primary code modifications across all three files.
Out of Scope Changes check	✅ Passed	All changes are narrowly scoped to sandbox naming for DGX Spark express install: documentation, installer script, and test updates directly address this single objective.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/issue-3945-express-onboard

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🌿 Preview your docs: https://nvidia-preview-pr-4521.docs.buildwithfern.com/nemoclaw

[github-actions]

E2E Advisor Recommendation

Required E2E: gpu-e2e, cloud-e2e
Optional E2E: docs-validation-e2e, wsl-repo-cloud-openclaw

Dispatch hint: gpu-e2e,cloud-e2e

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

• gpu-e2e (high): Closest existing E2E for the changed DGX Spark express path: runs install.sh --non-interactive with local Ollama, creates a sandbox, verifies auth proxy and local inference through the sandbox. This exercises the installer/onboard/local-inference lifecycle most likely to regress from the express-install provider/model defaults.
• cloud-e2e (high): Baseline full install → onboard → sandbox → OpenClaw prompt user journey using install.sh. Even though the diff is platform-specific, scripts/install.sh is runtime installer code, so a full installer/onboarding smoke is merge-blocking confidence.

Optional E2E

• docs-validation-e2e (low): Useful for the quickstart doc change because it installs NemoClaw and runs docs validation/parity checks, but the runtime risk is already covered by installer/onboarding E2E.
• wsl-repo-cloud-openclaw (high): The touched express-install helper also handles Windows WSL, although this PR only changes the DGX Spark sandbox default. Optional platform guard for ensuring WSL installer/onboard path remains healthy.

New E2E recommendations

• DGX Spark express install (high): Existing workflows do not expose a dispatchable DGX Spark express-install E2E. test/e2e/test-spark-install.sh exists but is not wired into nightly-e2e.yaml or scenario fan-out, and it does not appear to drive the interactive express prompt/default sandbox-name path added here.
  • Suggested test: Add a dispatchable DGX Spark express-install E2E/scenario that runs install.sh on a Spark-capable runner with a controlling TTY, accepts the express prompt, and asserts NEMOCLAW_SANDBOX_NAME defaults to my-spark-assistant, provider install-ollama, model qwen3.6:35b, suggested policy, sandbox creation, and local inference health.

Dispatch hint

• Workflow: nightly-e2e.yaml
• jobs input: gpu-e2e,cloud-e2e

[github-actions]

E2E Scenario Advisor Recommendation

Required scenario E2E: None
Optional scenario E2E: None

Workflow run

Full scenario advisor summary

E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required scenario E2E

• None. No scenario workflow, scenario metadata, scenario runtime, or validation-suite files changed.

Optional scenario E2E

• None.

Relevant changed files

• None.

[github-actions]

PR Review Advisor

Findings: 1 needs attention, 0 worth checking, 0 nice ideas
Since last review: 0 prior items resolved, 1 still applies, 0 new items found

Review findings

🛠️ Needs attention

• PR claims to fix [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945 but only addresses the sandbox-name clause: The linked issue [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945 contains multiple named DGX Spark express setup expectations. This patch implements the `my-spark-assistant` default and documents/tests that narrow behavior, but it does not implement the issue's Brave opt-in behavior, no-Brave-egress behavior when skipped/disabled, DNS utility availability, visible warm-up/pre-fetch step, or warning-on-warm-up-failure behavior. Because the PR body uses `Fixes [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945`, merging as-is would close an issue whose acceptance is still largely unmet.
  • Recommendation: Either narrow the PR linkage/description so it does not close [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945, or implement and test the remaining issue clauses before claiming the issue is fixed.
  • Evidence: PR body: `Fixes [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945`. Diff changes only `scripts/install.sh` DGX Spark express sandbox env/default summary, one quickstart line, and installer prompt tests. Issue [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945 expected results also require `Brave Web Search: SHOWN`, no egress widening to `api.search.brave.com` when Brave is skipped/disabled, DNS utility availability, and visible warm-up with warning-on-failure behavior.

🔎 Worth checking

• None.

🌱 Nice ideas

• None.

Since last review details

Current findings:

• PR claims to fix [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945 but only addresses the sandbox-name clause: The linked issue [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945 contains multiple named DGX Spark express setup expectations. This patch implements the `my-spark-assistant` default and documents/tests that narrow behavior, but it does not implement the issue's Brave opt-in behavior, no-Brave-egress behavior when skipped/disabled, DNS utility availability, visible warm-up/pre-fetch step, or warning-on-warm-up-failure behavior. Because the PR body uses `Fixes [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945`, merging as-is would close an issue whose acceptance is still largely unmet.
  • Recommendation: Either narrow the PR linkage/description so it does not close [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945, or implement and test the remaining issue clauses before claiming the issue is fixed.
  • Evidence: PR body: `Fixes [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945`. Diff changes only `scripts/install.sh` DGX Spark express sandbox env/default summary, one quickstart line, and installer prompt tests. Issue [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945 expected results also require `Brave Web Search: SHOWN`, no egress widening to `api.search.brave.com` when Brave is skipped/disabled, DNS utility availability, and visible warm-up with warning-on-failure behavior.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

[sandl99]

PR Review Advisor

Findings: 1 needs attention, 0 worth checking, 0 nice ideas Top item: PR only fixes sandbox naming while claiming Fixes #3945

Review findings

🛠️ Needs attention

• PR claims to fix [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945 but only addresses the sandbox-name clause: The linked issue [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945 contains multiple named expected-result clauses for DGX Spark express setup. This patch implements the my-spark-assistant default, but does not address the Brave opt-in behavior, DNS utility availability, visible warm-up/pre-fetch step, or warm-up failure warning clauses. Because the PR body uses Fixes [[Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945](https://github.com/NVIDIA/NemoClaw/issues/3945), merging as-is would close an issue whose acceptance is still largely unmet.

  • Recommendation: Either narrow the PR linkage/description so it does not close [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945, or implement and test the remaining issue clauses before claiming the issue is fixed.
  • Evidence: PR body: Fixes [[Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945](https://github.com/NVIDIA/NemoClaw/issues/3945). Diff only changes scripts/install.sh DGX Spark express sandbox env/default summary, one quickstart line, and installer prompt tests. Issue [Nemoclaw][Onboard][DGX Spark][DGX Station] Brave Web Search not prompted, sandbox default name mismatch, and nslookup missing in sandbox image and no surfaced warm-up step #3945 expected results also require Brave Web Search: SHOWN, no Brave egress when skipped/disabled, DNS utility availability, visible warm-up, and warning-on-warm-up-failure behavior.

🔎 Worth checking

• None.

🌱 Nice ideas

• None.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.