Skip to content

refactor(onboard): add core FSM flow slice#4487

Draft
cv wants to merge 1 commit into
stack/onboard-fsm-initial-sequence-slicefrom
stack/onboard-fsm-core-sequence-slice
Draft

refactor(onboard): add core FSM flow slice#4487
cv wants to merge 1 commit into
stack/onboard-fsm-initial-sequence-slicefrom
stack/onboard-fsm-core-sequence-slice

Conversation

@cv
Copy link
Copy Markdown
Collaborator

@cv cv commented May 29, 2026

Summary

Add a reusable core onboarding flow slice for provider/inference and sandbox. This slice can start at provider_selection, apply the provider/sandbox FSM results, and stop at the selected branch state.

Changes

  • Add coreOnboardFlowPhases() for provider/inference and sandbox phases.
  • Add runCoreOnboardFlowSequence() with stop states for openclaw and agent_setup.
  • Add tests for phase selection and branch-state handoff.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv self-assigned this May 29, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 29, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 72dc428f-e396-48be-a986-89b2ef56bd52

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stack/onboard-fsm-core-sequence-slice

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: scenario:ubuntu-repo-cloud-openclaw
Optional E2E: scenario:ubuntu-repo-cloud-hermes, scenario:ubuntu-repo-cloud-openclaw-resume

Dispatch hint: scenarios=ubuntu-repo-cloud-openclaw

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/stack/onboard-fsm-initial-sequence-slice
Head: HEAD
Confidence: medium

Required E2E

  • scenario:ubuntu-repo-cloud-openclaw (high): Covers the canonical Ubuntu repo cloud OpenClaw onboarding path through provider selection, sandbox setup, OpenClaw readiness, smoke, inference, and credentials checks. This is the closest existing E2E guard for the provider_selection -> sandbox -> openclaw flow boundary changed here.

Optional E2E

  • scenario:ubuntu-repo-cloud-hermes (high): Useful adjacent coverage for the alternate agent_setup branch stop state added by runCoreOnboardFlowSequence; not merge-blocking because the changed helper currently appears newly introduced and the OpenClaw path is the primary flow.
  • scenario:ubuntu-repo-cloud-openclaw-resume (high): Useful confidence for interrupted/resumed onboarding around sliced flow execution boundaries, especially if the new core slice is intended to be used after an initial preflight/gateway slice.

New E2E recommendations

  • onboarding-flow-state-machine (medium): Existing E2E scenarios validate full onboarding outcomes but do not appear to directly assert the new initial/core slice boundary contract: initial slice stops at provider_selection, core slice resumes from provider_selection and stops at openclaw or agent_setup.
    • Suggested test: Add a focused E2E or scenario assertion that drives onboarding in two slices: preflight/gateway to provider_selection, then provider_selection/sandbox to both OpenClaw and alternate agent setup stop states, verifying session machine state after each slice.

Dispatch hint

  • Workflow: .github/workflows/e2e-scenarios.yaml
  • jobs input: scenarios=ubuntu-repo-cloud-openclaw

@github-actions
Copy link
Copy Markdown
Contributor

E2E Scenario Advisor Recommendation

Required scenario E2E: None
Optional scenario E2E: None

Workflow run

Full scenario advisor summary

E2E Scenario Advisor

Base: origin/stack/onboard-fsm-initial-sequence-slice
Head: HEAD
Confidence: high

Required scenario E2E

  • None. No scenario workflow, scenario metadata, scenario runtime, or validation-suite files changed.

Optional scenario E2E

  • None.

Relevant changed files

  • None.

@github-actions
Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 0 worth checking, 0 nice ideas
Top item: No actionable findings

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@cv cv added the onboarding Making the onboarding experience better label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

onboarding Making the onboarding experience better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant