refactor: enforce declarative architecture locations - #441
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 1222 files, which is 1122 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (97)
📒 Files selected for processing (1222)
You can disable this status message by setting the |
Deploying living-architecture with
|
| Latest commit: |
3a2ff26
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ff05e384.living-architecture.pages.dev |
| Branch Preview URL: | https://codex-rle-location-rules.living-architecture.pages.dev |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
NTCoding
force-pushed
the
codex/rle-location-rules
branch
from
August 14, 2026 18:27
085ac0d to
3a2ff26
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Architecture policy was split between ADR-002, role enforcement, Dependency Cruiser, and external guidance. That allowed the rules to drift and left important location boundaries unclear or unenforced.
Outcome
ADR-002 and the local Rivière role-enforcement configuration are now aligned sources of truth for the standard packages. Broad location rules define permitted folders and dependencies; roles add finer restrictions only where needed.
Éclair is deliberately unchanged and remains outside Rivière role enforcement. Its existing
.dependency-cruiser.frontend.mjscheck stays in the verification gate until Éclair is migrated separately.Changes
location(...).subLocation(...)_platformvisibilityRiviereQueryinto its domain and replace the generic query repository with concrete per-use-case query loadersAcceptance criteria
_platformcode is importable only from within its parent locationValidation
main: lint, Markdown lint, role checks, builds, typechecks, tests, generated-doc checks, Knip, docs build, and Éclair Dependency Cruisermaincontains no files underapps/eclair