Skip to content

ci: fix Vulkan GPU gate runner path initialization - #234

Merged
Irk2wd merged 1 commit into
mainfrom
codex/phase27b-vulkan-gpu-ci-workflow-parse
Aug 1, 2026
Merged

ci: fix Vulkan GPU gate runner path initialization#234
Irk2wd merged 1 commit into
mainfrom
codex/phase27b-vulkan-gpu-ci-workflow-parse

Conversation

@Irk2wd

@Irk2wd Irk2wd commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move GPU build/output path initialization out of job-level env, where the runner context is unavailable
  • derive the same per-run paths from RUNNER_TEMP inside a Windows PowerShell step
  • preserve evidence paths, trust boundaries, and all downstream environment-variable contracts

Root cause

The first post-merge dispatch of Phase 27 was rejected by GitHub before creating a run: runner.temp is not an allowed expression context in jobs.gpu_validation.env.

Validation

  • GitHub service accepted branch dispatch run https://github.com/NJUCG/MoerEngine/actions/runs/30695539710 for exact head e78934c51ab718667c0dcf17ea0b80db84e4301a
  • branch dispatch then failed closed as designed with manual_dispatch_requires_main; GPU job was skipped
  • Python runner contracts: 164/164 PASS
  • PowerShell 5.1 AST and spaced-path probe: PASS
  • YAML parse and git diff --check: PASS
  • independent P0-P2 review: clean

After merge, the workflow will be dispatched on main for the real protected-environment GPU qualification.

@Irk2wd

Irk2wd commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head e78934c51ab718667c0dcf17ea0b80db84e4301a, focusing on whether moving runner.temp from job-level env to a PowerShell step using RUNNER_TEMP/GITHUB_ENV is valid on Windows PowerShell 5.1, whether all downstream steps receive BUILD_DIR/OUTPUT_DIR, and whether this creates any fail-open or injection issue. Report remaining P0-P2 issues.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: e78934c51a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Irk2wd
Irk2wd merged commit d3502d6 into main Aug 1, 2026
3 of 5 checks passed
@Irk2wd
Irk2wd deleted the codex/phase27b-vulkan-gpu-ci-workflow-parse branch August 1, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant