Skip to content

docs(protocol): complete v2 migration docs and tests (step 9)#92

Merged
arkanoider merged 1 commit into
mainfrom
feat/protocol-v2-tests-docs-step9
Jun 20, 2026
Merged

docs(protocol): complete v2 migration docs and tests (step 9)#92
arkanoider merged 1 commit into
mainfrom
feat/protocol-v2-tests-docs-step9

Conversation

@arkanoider

Copy link
Copy Markdown
Collaborator

###Summary
Closes protocol v2 step 9: documentation polish for dual-transport protocol DMs and two unit tests. No runtime behavior changes. Follows #91; completes the migration plan.

Changes
docs/DM_LISTENER_FLOW.md — dual-transport table + mermaid; unwrap_incoming fix; manual verification checklist
docs/README.md + README.md — v2 complete wording; auto-select transport; pow_first_contact note
src/util/filters.rs — v1 filter shape test (kind 1059, no authors)
src/util/mostro_info.rs — is_v2_first_contact_protocol_action test

Document dual-transport subscribe/decrypt flow, manual verification checklist,
and v2-complete README copy. Add filter and first-contact action unit tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@arkanoider, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 27 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5d56a572-8adb-4acb-a364-dbbc6e43d168

📥 Commits

Reviewing files that changed from the base of the PR and between cdc0cb1 and 993556e.

📒 Files selected for processing (5)
  • README.md
  • docs/DM_LISTENER_FLOW.md
  • docs/README.md
  • src/util/filters.rs
  • src/util/mostro_info.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/protocol-v2-tests-docs-step9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mostronatorcoder

Copy link
Copy Markdown
Contributor

I did a pass on this PR and I do not see a blocker here.

This looks like the right kind of finishing slice for step 9:

  • docs updated to describe the final dual-transport state more explicitly
  • the added filter test usefully locks in the important v1 invariant that GiftWrap subscriptions must not constrain authors
  • the added first-contact action test also helps prevent accidental widening/narrowing of the v2 PoW rule later

So from my side this is a good docs/tests follow-up and I do not see any correctness concern in the changes shown here.

@ermeme ermeme Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approve

Docs and tests look consistent with the current transport behavior. The new coverage checks the v1 filter shape and the v2 first-contact action gate, and the docs now match the implemented dual-transport flow.

@arkanoider arkanoider merged commit c0b831b into main Jun 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant